Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 381833002: Move demo mode preference registration. (Closed)

Created:
6 years, 5 months ago by rkc
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move demo mode preference registration. Move the register preferences code for the demo mode detector to the correct location. Need owners reviews for c/b/prefs and c/b/ui/webui/login. R=merkulova@chromium.org, mnissler@chromium.org, nkostylev@chromium.org BUG=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rkc
6 years, 5 months ago (2014-07-10 00:35:42 UTC) #1
Nikita (slow)
lgtm
6 years, 5 months ago (2014-07-14 09:26:57 UTC) #2
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 5 months ago (2014-07-14 10:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/381833002/1
6 years, 5 months ago (2014-07-14 10:30:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 12:12:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 12:16:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79725)
6 years, 5 months ago (2014-07-14 12:16:25 UTC) #7
merkulova
lgtm
6 years, 5 months ago (2014-07-16 10:38:12 UTC) #8
rkc
Adding battre@ for c/b/prefs owners review since Mattias is OOO.
6 years, 5 months ago (2014-07-16 11:05:21 UTC) #9
battre
lgtm
6 years, 5 months ago (2014-07-16 11:19:55 UTC) #10
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 5 months ago (2014-07-16 17:43:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/381833002/1
6 years, 5 months ago (2014-07-16 17:46:02 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 17:54:06 UTC) #13
Message was sent while issue was closed.
Change committed as 283420

Powered by Google App Engine
This is Rietveld 408576698