Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: media/base/audio_renderer_mixer_input_unittest.cc

Issue 381823003: Allow AudioRendererMixerInputs to be restarted after stopped. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_renderer_mixer_input.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer_mixer_input_unittest.cc
diff --git a/media/base/audio_renderer_mixer_input_unittest.cc b/media/base/audio_renderer_mixer_input_unittest.cc
index 9a019db57171c8284b62d4b3f97e77b03117dd91..be03867027f0963bc38fca13eb386827948527d7 100644
--- a/media/base/audio_renderer_mixer_input_unittest.cc
+++ b/media/base/audio_renderer_mixer_input_unittest.cc
@@ -28,7 +28,6 @@ class AudioRendererMixerInputTest : public testing::Test {
CreateMixerInput();
fake_callback_.reset(new FakeAudioRenderCallback(0));
mixer_input_->Initialize(audio_parameters_, fake_callback_.get());
- EXPECT_CALL(*this, RemoveMixer(testing::_));
audio_bus_ = AudioBus::Create(audio_parameters_);
}
@@ -49,6 +48,7 @@ class AudioRendererMixerInputTest : public testing::Test {
mixer_.reset(new AudioRendererMixer(
audio_parameters_, audio_parameters_, sink));
}
+ EXPECT_CALL(*this, RemoveMixer(testing::_));
return mixer_.get();
}
@@ -109,4 +109,12 @@ TEST_F(AudioRendererMixerInputTest, StopBeforeInitializeOrStart) {
mixer_input_->Stop();
}
+// Test that Start() can be called after Stop().
+// TODO(dalecurtis): We shouldn't allow this. See http://crbug.com/151051
+TEST_F(AudioRendererMixerInputTest, StartAfterStop) {
+ mixer_input_->Stop();
+ mixer_input_->Start();
+ mixer_input_->Stop();
+}
+
} // namespace media
« no previous file with comments | « media/base/audio_renderer_mixer_input.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698