Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tools/telemetry/telemetry/value/histogram_unittest.py

Issue 381723002: Refactor Telemetry value system to support AsDict() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/histogram_unittest.py
diff --git a/tools/telemetry/telemetry/value/histogram_unittest.py b/tools/telemetry/telemetry/value/histogram_unittest.py
index ba75b5e4faa6fa2e94c373cc5ac7a95c3625dbd8..adeb16b6b2e4adad60bf3c32b53686c0109c4917 100644
--- a/tools/telemetry/telemetry/value/histogram_unittest.py
+++ b/tools/telemetry/telemetry/value/histogram_unittest.py
@@ -42,3 +42,24 @@ class ValueTest(TestBase):
self.assertEquals(
'histogram',
histogram.GetBuildbotDataType(value.SUMMARY_RESULT_OUTPUT_CONTEXT))
+
+ def testBucketAsDict(self):
+ bucket = histogram_module.HistogramValueBucket(33, 45, 78)
+ d = bucket.AsDict()
+
+ self.assertEquals(d, {
+ 'low': 33,
+ 'high': 45,
+ 'count': 78
+ })
+
+ def testAsDictIsAccurate(self):
+ histogram = histogram_module.HistogramValue(
+ None, 'x', 'counts',
+ raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
+ important=False)
+ d = histogram.AsDictWithoutBaseClassEntries()
+
+ self.assertEquals(['buckets'], d.keys())
+ self.assertTrue(isinstance(d['buckets'], list))
+ self.assertEquals(len(d['buckets']), 1)
« no previous file with comments | « tools/telemetry/telemetry/value/histogram.py ('k') | tools/telemetry/telemetry/value/list_of_scalar_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698