Explicitly resize inner viewport container layer on SetViewportSize

Explicitly resize inner viewport container layer on SetViewportSize

SetViewportSize previously relied on UpdateInnerViewportContainerSize to
resize the inner viewport container layer; however, as of r253909, this
method is a no-op if the container layer has masks_to_bounds set (i.e.
non-Android platforms).

This fix explicitly resizes the inner viewport container layer to be the
same size as the newly resized device viewport before calling
UpdateInnerViewportContainerSize. This fixes the situation in the bug
where the viewport size is changed but nothing in the layer tree changes
so no new frame is committed.

BUG=387678
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282687

[bokan, 2014-07-09 17:02:22]

Alexandre, PTAL. Thanks.

[aelias_OOO_until_Jul13, 2014-07-11 00:06:26]

If I understand correctly, you're forcing an update-draw-properties by
temporarily changing the viewport size to something bogus then letting
UpdateInnerViewportContainerSize change it back?  That seems wrong.  Could you
explicitly call "layer_tree_impl()->set_needs_update_draw_properties();" from
SetViewportSize instead?

[bokan, 2014-07-11 18:14:50]

On 2014/07/11 00:06:26, aelias wrote:
> If I understand correctly, you're forcing an update-draw-properties by
> temporarily changing the viewport size to something bogus then letting
> UpdateInnerViewportContainerSize change it back?  That seems wrong.  Could you
> explicitly call "layer_tree_impl()->set_needs_update_draw_properties();" from
> SetViewportSize instead?

It's not a bogus value, I think it's what the inner viewport container layer
would eventually be set to (when we do a commit); however,
UpdateInnerViewportContainerSize on desktop does the non-nonsensical thing of
setting the bounds from the inner viewport container layer's bounds i.e. setting
it to itself. This seems wrong to me, though I don't understand the nuances
here. I'd like to drill down and understand fully what's going on here
(hopefully simplify and unify the desktop-Android divergence eventually) but I
think we'll want to merge this. What you suggested works so it's also possible
I'm overthinking/misunderstanding this, I've updated the CL to just call
set_needs_update_draw_properties. I'll look into it further when I return from
vacation. PTAL?

[aelias_OOO_until_Jul13, 2014-07-11 18:18:42]

On 2014/07/11 at 18:14:50, bokan wrote:
> On 2014/07/11 00:06:26, aelias wrote:
> > If I understand correctly, you're forcing an update-draw-properties by
> > temporarily changing the viewport size to something bogus then letting
> > UpdateInnerViewportContainerSize change it back?  That seems wrong.  Could
you
> > explicitly call "layer_tree_impl()->set_needs_update_draw_properties();"
from
> > SetViewportSize instead?
> 
> It's not a bogus value, I think it's what the inner viewport container layer
would eventually be set to (when we do a commit); however,
UpdateInnerViewportContainerSize on desktop does the non-nonsensical thing of
setting the bounds from the inner viewport container layer's bounds i.e. setting
it to itself. This seems wrong to me, though I don't understand the nuances
here. I'd like to drill down and understand fully what's going on here
(hopefully simplify and unify the desktop-Android divergence eventually) but I
think we'll want to merge this. What you suggested works so it's also possible
I'm overthinking/misunderstanding this, I've updated the CL to just call
set_needs_update_draw_properties. I'll look into it further when I return from
vacation. PTAL?

OK, lgtm for that one-liner.

I'd also very much like to unify the platforms here.  The main blocker is to
make Blink aware of top controls size on Android.  Because Blink doesn't know
about top controls size, CC can't trust any size Blink gives it on Android and
has to derive from the physical viewport size instead.

[bokan, 2014-07-11 18:21:47]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-07-11 18:23:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bokan@chromium.org/381703002/20001

[commit-bot: I haz the power, 2014-07-11 20:29:32]

Change committed as 282687