Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 381683002: [Android] Cache injected Java objects' methods info on renderer side (Closed)

Created:
6 years, 5 months ago by mnaganov (inactive)
Modified:
6 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[Android] Cache injected Java objects' methods info on renderer side Every invocation of Java method via an interface JS wrapper injected by Java bridge is preceded by a call to GetNamedProperty. As method presence can't change during Java object's lifetime, we should cache it on the renderer side, as every IPC call to the browser side is super-expensive. This optimization improves Cordova's "exec" benchmark speed by astonishing 60%, as we shave off half of the IPC calls. BUG=355644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/renderer/java/gin_java_bridge_object.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/java/gin_java_bridge_object.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mnaganov (inactive)
6 years, 5 months ago (2014-07-09 16:01:49 UTC) #1
mnaganov (inactive)
6 years, 5 months ago (2014-07-09 16:01:56 UTC) #2
Torne
lgtm
6 years, 5 months ago (2014-07-10 10:56:04 UTC) #3
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-10 11:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/381683002/1
6 years, 5 months ago (2014-07-10 11:03:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 15:11:55 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:22:14 UTC) #7
Message was sent while issue was closed.
Change committed as 282345

Powered by Google App Engine
This is Rietveld 408576698