Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 381643003: Add chrome/service to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/service/BUILD.gn View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 5 months ago (2014-07-09 18:12:36 UTC) #1
jamesr
Is this list just not big enough to pull to a gypi? lgtm
6 years, 5 months ago (2014-07-09 19:45:55 UTC) #2
brettw
On 2014/07/09 19:45:55, jamesr wrote: > Is this list just not big enough to pull ...
6 years, 5 months ago (2014-07-09 20:00:36 UTC) #3
brettw
6 years, 5 months ago (2014-07-09 20:13:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r282107.

Powered by Google App Engine
This is Rietveld 408576698