Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: content/renderer/render_frame_impl.h

Issue 381633005: Refactor Web Notification permission requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/notification_permission_dispatcher.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 8b2c98dc285ca76642deace6ee84e944045e3a3a..554799d252ab6e479680262d05356c5fbd3a3235 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -64,6 +64,7 @@ class MediaStreamDispatcher;
class MediaStreamImpl;
class MediaStreamRendererFactory;
class MidiDispatcher;
+class NotificationPermissionDispatcher;
class NotificationProvider;
class PepperPluginInstanceImpl;
class PushMessagingDispatcher;
@@ -338,6 +339,9 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebHistoryCommitType commit_type);
virtual void didUpdateCurrentHistoryItem(blink::WebLocalFrame* frame);
virtual void didChangeThemeColor();
+ virtual void requestNotificationPermission(
+ const blink::WebSecurityOrigin& origin,
+ blink::WebNotificationPermissionCallback* callback);
virtual blink::WebNotificationPresenter* notificationPresenter();
virtual void didChangeSelection(bool is_empty_selection);
virtual blink::WebColorChooser* createColorChooser(
@@ -647,7 +651,11 @@ class CONTENT_EXPORT RenderFrameImpl
// along with the RenderFrame automatically. This is why we just store weak
// references.
+ // Dispatches permission requests for Web Notifications.
+ NotificationPermissionDispatcher* notification_permission_dispatcher_;
+
// Holds a reference to the service which provides desktop notifications.
+ // TODO(peter) Remove this once Web Notifications are routed through Platform.
NotificationProvider* notification_provider_;
// Destroyed via the RenderFrameObserver::OnDestruct() mechanism.
« no previous file with comments | « content/renderer/notification_permission_dispatcher.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698