Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: content/renderer/render_frame_impl.h

Issue 381633005: Refactor Web Notification permission requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 5fca735a83f6f8e994616e0873b4f9b498506675..b070b502f21685652dcf9f6756a98e63367b54ba 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -60,6 +60,7 @@ class ChildFrameCompositingHelper;
class GeolocationDispatcher;
class MediaStreamRendererFactory;
class MidiDispatcher;
+class NotificationPermissionDispatcher;
class NotificationProvider;
class PepperPluginInstanceImpl;
class PushMessagingDispatcher;
@@ -312,6 +313,9 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebHistoryCommitType commit_type);
virtual void didUpdateCurrentHistoryItem(blink::WebLocalFrame* frame);
virtual void didChangeBrandColor();
+ virtual void requestNotificationPermission(
+ const blink::WebSecurityOrigin& origin,
+ blink::WebNotificationPermissionCallback* callback);
virtual blink::WebNotificationPresenter* notificationPresenter();
virtual void didChangeSelection(bool is_empty_selection);
virtual blink::WebColorChooser* createColorChooser(
@@ -616,7 +620,11 @@ class CONTENT_EXPORT RenderFrameImpl
// along with the RenderFrame automatically. This is why we just store weak
// references.
+ // Dispatches permission requests for Web Notifications.
+ NotificationPermissionDispatcher* notification_permission_dispatcher_;
+
// Holds a reference to the service which provides desktop notifications.
+ // TODO(peter) Remove this once Web Notifications are routed through Platform.
NotificationProvider* notification_provider_;
blink::WebUserMediaClient* web_user_media_client_;

Powered by Google App Engine
This is Rietveld 408576698