Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-arm.h" 7 #include "src/arm/lithium-arm.h"
8 #include "src/arm/lithium-codegen-arm.h" 8 #include "src/arm/lithium-codegen-arm.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/lithium-allocator-inl.h" 10 #include "src/lithium-allocator-inl.h"
(...skipping 2237 matching lines...) Expand 10 before | Expand all | Expand 10 after
2248 instr->elements()->representation().IsExternal())); 2248 instr->elements()->representation().IsExternal()));
2249 LOperand* val = UseRegister(instr->value()); 2249 LOperand* val = UseRegister(instr->value());
2250 LOperand* key = UseRegisterOrConstantAtStart(instr->key()); 2250 LOperand* key = UseRegisterOrConstantAtStart(instr->key());
2251 LOperand* backing_store = UseRegister(instr->elements()); 2251 LOperand* backing_store = UseRegister(instr->elements());
2252 return new(zone()) LStoreKeyed(backing_store, key, val); 2252 return new(zone()) LStoreKeyed(backing_store, key, val);
2253 } 2253 }
2254 2254
2255 2255
2256 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) { 2256 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) {
2257 LOperand* context = UseFixed(instr->context(), cp); 2257 LOperand* context = UseFixed(instr->context(), cp);
2258 LOperand* obj = UseFixed(instr->object(), r2); 2258 LOperand* obj = UseFixed(instr->object(), KeyedStoreIC::ReceiverRegister());
2259 LOperand* key = UseFixed(instr->key(), r1); 2259 LOperand* key = UseFixed(instr->key(), KeyedStoreIC::NameRegister());
2260 LOperand* val = UseFixed(instr->value(), r0); 2260 LOperand* val = UseFixed(instr->value(), KeyedStoreIC::ValueRegister());
2261 2261
2262 ASSERT(instr->object()->representation().IsTagged()); 2262 ASSERT(instr->object()->representation().IsTagged());
2263 ASSERT(instr->key()->representation().IsTagged()); 2263 ASSERT(instr->key()->representation().IsTagged());
2264 ASSERT(instr->value()->representation().IsTagged()); 2264 ASSERT(instr->value()->representation().IsTagged());
2265 2265
2266 return MarkAsCall( 2266 return MarkAsCall(
2267 new(zone()) LStoreKeyedGeneric(context, obj, key, val), instr); 2267 new(zone()) LStoreKeyedGeneric(context, obj, key, val), instr);
2268 } 2268 }
2269 2269
2270 2270
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
2324 2324
2325 // We need a temporary register for write barrier of the map field. 2325 // We need a temporary register for write barrier of the map field.
2326 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2326 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2327 2327
2328 return new(zone()) LStoreNamedField(obj, val, temp); 2328 return new(zone()) LStoreNamedField(obj, val, temp);
2329 } 2329 }
2330 2330
2331 2331
2332 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2332 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2333 LOperand* context = UseFixed(instr->context(), cp); 2333 LOperand* context = UseFixed(instr->context(), cp);
2334 LOperand* obj = UseFixed(instr->object(), r1); 2334 LOperand* obj = UseFixed(instr->object(), StoreIC::ReceiverRegister());
2335 LOperand* val = UseFixed(instr->value(), r0); 2335 LOperand* val = UseFixed(instr->value(), StoreIC::ValueRegister());
2336 2336
2337 LInstruction* result = new(zone()) LStoreNamedGeneric(context, obj, val); 2337 LInstruction* result = new(zone()) LStoreNamedGeneric(context, obj, val);
2338 return MarkAsCall(result, instr); 2338 return MarkAsCall(result, instr);
2339 } 2339 }
2340 2340
2341 2341
2342 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2342 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2343 LOperand* context = UseFixed(instr->context(), cp); 2343 LOperand* context = UseFixed(instr->context(), cp);
2344 LOperand* left = UseFixed(instr->left(), r1); 2344 LOperand* left = UseFixed(instr->left(), r1);
2345 LOperand* right = UseFixed(instr->right(), r0); 2345 LOperand* right = UseFixed(instr->right(), r0);
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
2589 LInstruction* LChunkBuilder::DoAllocateBlockContext( 2589 LInstruction* LChunkBuilder::DoAllocateBlockContext(
2590 HAllocateBlockContext* instr) { 2590 HAllocateBlockContext* instr) {
2591 LOperand* context = UseFixed(instr->context(), cp); 2591 LOperand* context = UseFixed(instr->context(), cp);
2592 LOperand* function = UseRegisterAtStart(instr->function()); 2592 LOperand* function = UseRegisterAtStart(instr->function());
2593 LAllocateBlockContext* result = 2593 LAllocateBlockContext* result =
2594 new(zone()) LAllocateBlockContext(context, function); 2594 new(zone()) LAllocateBlockContext(context, function);
2595 return MarkAsCall(DefineFixed(result, cp), instr); 2595 return MarkAsCall(DefineFixed(result, cp), instr);
2596 } 2596 }
2597 2597
2598 } } // namespace v8::internal 2598 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698