Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/arm/debug-arm.cc

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) { 177 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
178 // Calling convention for IC load (from ic-arm.cc). 178 // Calling convention for IC load (from ic-arm.cc).
179 Register receiver = LoadIC::ReceiverRegister(); 179 Register receiver = LoadIC::ReceiverRegister();
180 Register name = LoadIC::NameRegister(); 180 Register name = LoadIC::NameRegister();
181 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0); 181 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0);
182 } 182 }
183 183
184 184
185 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 185 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
186 // Calling convention for IC store (from ic-arm.cc). 186 // Calling convention for IC store (from ic-arm.cc).
187 // ----------- S t a t e ------------- 187 Register receiver = StoreIC::ReceiverRegister();
188 // -- r0 : value 188 Register name = StoreIC::NameRegister();
189 // -- r1 : receiver 189 Register value = StoreIC::ValueRegister();
190 // -- r2 : name 190 Generate_DebugBreakCallHelper(
191 // -- lr : return address 191 masm, receiver.bit() | name.bit() | value.bit(), 0);
192 // -----------------------------------
193 // Registers r0, r1, and r2 contain objects that need to be pushed on the
194 // expression stack of the fake JS frame.
195 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0);
196 } 192 }
197 193
198 194
199 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 195 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
200 // Calling convention for keyed IC load (from ic-arm.cc). 196 // Calling convention for keyed IC load (from ic-arm.cc).
201 GenerateLoadICDebugBreak(masm); 197 GenerateLoadICDebugBreak(masm);
202 } 198 }
203 199
204 200
205 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 201 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
206 // ---------- S t a t e -------------- 202 // Calling convention for IC keyed store call (from ic-arm.cc).
207 // -- r0 : value 203 Register receiver = KeyedStoreIC::ReceiverRegister();
208 // -- r1 : key 204 Register name = KeyedStoreIC::NameRegister();
209 // -- r2 : receiver 205 Register value = KeyedStoreIC::ValueRegister();
210 // -- lr : return address 206 Generate_DebugBreakCallHelper(
211 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0); 207 masm, receiver.bit() | name.bit() | value.bit(), 0);
212 } 208 }
213 209
214 210
215 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 211 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
216 // Register state for CompareNil IC 212 // Register state for CompareNil IC
217 // ----------- S t a t e ------------- 213 // ----------- S t a t e -------------
218 // -- r0 : value 214 // -- r0 : value
219 // ----------------------------------- 215 // -----------------------------------
220 Generate_DebugBreakCallHelper(masm, r0.bit(), 0); 216 Generate_DebugBreakCallHelper(masm, r0.bit(), 0);
221 } 217 }
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 } 315 }
320 316
321 317
322 const bool LiveEdit::kFrameDropperSupported = true; 318 const bool LiveEdit::kFrameDropperSupported = true;
323 319
324 #undef __ 320 #undef __
325 321
326 } } // namespace v8::internal 322 } } // namespace v8::internal
327 323
328 #endif // V8_TARGET_ARCH_ARM 324 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698