components/autofill/core/browser/phone_field.cc - Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_field.cc

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/phone_field.cc

diff --git a/components/autofill/core/browser/phone_field.cc b/components/autofill/core/browser/phone_field.cc

index 34f4c58e99de1df829e70fa14069e8868c0296d7..1d573251c1717c46ffb920cce938e481d3a33742 100644

--- a/components/autofill/core/browser/phone_field.cc

+++ b/components/autofill/core/browser/phone_field.cc

@@ -125,7 +125,7 @@ FormField* PhoneField::Parse(AutofillScanner* scanner) {

scanner->SaveCursor();

// The form owns the following variables, so they should not be deleted.

- const AutofillField* parsed_fields[FIELD_MAX];

+ AutofillField* parsed_fields[FIELD_MAX];

for (size_t i = 0; i < arraysize(kPhoneFieldGrammars); ++i) {

memset(parsed_fields, 0, sizeof(parsed_fields));

« no previous file with comments | « components/autofill/core/browser/phone_field.h ('k') | components/autofill/core/browser/phone_field_unittest.cc » ('j') | no next file with comments »