Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: components/autofill/core/browser/form_field.h

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review inputs. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/email_field.cc ('k') | components/autofill/core/browser/form_field.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/form_field.h
diff --git a/components/autofill/core/browser/form_field.h b/components/autofill/core/browser/form_field.h
index c4243210c1f2dae9d5ca35e511f8af3c5434cc74..10fac68969b7ba86893886ed7268dbd2ae73a589 100644
--- a/components/autofill/core/browser/form_field.h
+++ b/components/autofill/core/browser/form_field.h
@@ -59,7 +59,7 @@ class FormField {
// success and fills |match| with a pointer to the field.
static bool ParseField(AutofillScanner* scanner,
const base::string16& pattern,
- const AutofillField** match);
+ AutofillField** match);
// Parses the stream of fields in |scanner| with regular expression |pattern|
// as specified in the |match_type| bit field (see |MatchType|). If |match|
@@ -69,12 +69,11 @@ class FormField {
static bool ParseFieldSpecifics(AutofillScanner* scanner,
const base::string16& pattern,
int match_type,
- const AutofillField** match);
+ AutofillField** match);
// Attempts to parse a field with an empty label. Returns true
// on success and fills |match| with a pointer to the field.
- static bool ParseEmptyLabel(AutofillScanner* scanner,
- const AutofillField** match);
+ static bool ParseEmptyLabel(AutofillScanner* scanner, AutofillField** match);
// Adds an association between a field and a type to |map|.
static bool AddClassification(const AutofillField* field,
@@ -101,7 +100,7 @@ class FormField {
static bool MatchAndAdvance(AutofillScanner* scanner,
const base::string16& pattern,
int match_type,
- const AutofillField** match);
+ AutofillField** match);
// Matches the regular expression |pattern| against the components of |field|
// as specified in the |match_type| bit field (see |MatchType|).
@@ -115,7 +114,7 @@ class FormField {
// holds any remaining unclassified fields for further processing.
// Classification results of the processed fields are stored in |map|.
static void ParseFormFieldsPass(ParseFunction parse,
- std::vector<const AutofillField*>* fields,
+ std::vector<AutofillField*>* fields,
ServerFieldTypeMap* map);
// Returns true iff |type| matches |match_type|.
« no previous file with comments | « components/autofill/core/browser/email_field.cc ('k') | components/autofill/core/browser/form_field.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698