Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/autofill/core/browser/autofill_scanner.h

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review inputs. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_scanner.h
diff --git a/components/autofill/core/browser/autofill_scanner.h b/components/autofill/core/browser/autofill_scanner.h
index 2a634e6d8aae02104add8b1a70f443df69411d90..db3f3baf7d0f9cc3165922e4f225990291d41677 100644
--- a/components/autofill/core/browser/autofill_scanner.h
+++ b/components/autofill/core/browser/autofill_scanner.h
@@ -17,7 +17,7 @@ class AutofillField;
// A helper class for parsing a stream of |AutofillField|'s with lookahead.
class AutofillScanner {
public:
- explicit AutofillScanner(const std::vector<const AutofillField*>& fields);
+ explicit AutofillScanner(std::vector<AutofillField*>& fields);
~AutofillScanner();
// Advances the cursor by one step, if possible.
@@ -25,7 +25,7 @@ class AutofillScanner {
// Returns the current field in the stream, or |NULL| if there are no more
// fields in the stream.
- const AutofillField* Cursor() const;
+ AutofillField* Cursor() const;
// Returns |true| if the cursor has reached the end of the stream.
bool IsEnd() const;
@@ -42,16 +42,16 @@ class AutofillScanner {
private:
// Indicates the current position in the stream, represented as a vector.
- std::vector<const AutofillField*>::const_iterator cursor_;
+ std::vector<AutofillField*>::const_iterator cursor_;
// The most recently saved cursor.
- std::vector<const AutofillField*>::const_iterator saved_cursor_;
+ std::vector<AutofillField*>::const_iterator saved_cursor_;
// The beginning pointer for the stream.
- const std::vector<const AutofillField*>::const_iterator begin_;
+ const std::vector<AutofillField*>::iterator begin_;
// The past-the-end pointer for the stream.
- const std::vector<const AutofillField*>::const_iterator end_;
+ const std::vector<AutofillField*>::iterator end_;
DISALLOW_COPY_AND_ASSIGN(AutofillScanner);
};
« no previous file with comments | « components/autofill/core/browser/autofill_field_unittest.cc ('k') | components/autofill/core/browser/autofill_scanner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698