[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/credit_card_field_unittest.cc

Index: components/autofill/core/browser/credit_card_field_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_field_unittest.cc b/components/autofill/core/browser/credit_card_field_unittest.cc
index 037a302c340359eaef21595384e09f04342dddfc..8b3c5545e1f70cf941021df7528db1655ac39afb 100644
--- a/components/autofill/core/browser/credit_card_field_unittest.cc
+++ b/components/autofill/core/browser/credit_card_field_unittest.cc
@@ -347,4 +347,64 @@ TEST_F(CreditCardFieldTest, ParseMonthControl) {
             field_type_map_[ASCIIToUTF16("date2")]);
 }
 
+TEST_F(CreditCardFieldTest, ParseCreditCardNumberWithSplit) {
+  FormFieldData field;
+  field.form_control_type = "text";
+
+  field.label = ASCIIToUTF16("Card Number");
+  field.name = ASCIIToUTF16("card_number_q1");
+  field.max_length = 4;
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("number1")));
+
+  field.label = ASCIIToUTF16("Card Number");
+  field.name = ASCIIToUTF16("card_number_q2");
+  field.max_length = 4;
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("number2")));
+
+  field.label = ASCIIToUTF16("Card Number");
+  field.name = ASCIIToUTF16("card_number_q3");
+  field.max_length = 4;
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("number3")));
+
+  field.label = ASCIIToUTF16("Card Number");
+  field.name = ASCIIToUTF16("card_number_q4");
+  field.max_length = 4;
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("number4")));
+
+  field.label = ASCIIToUTF16("Exp Month");
+  field.name = ASCIIToUTF16("ccmonth");
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("month5")));
+
+  field.label = ASCIIToUTF16("Exp Year");
+  field.name = ASCIIToUTF16("ccyear");
+  list_.push_back(new AutofillField(field, ASCIIToUTF16("year6")));
+
+  Parse();
+  ASSERT_NE(static_cast<CreditCardField*>(NULL), field_.get());
+  EXPECT_TRUE(ClassifyField());
+
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number1")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number1")]);
+
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number2")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
+
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number3")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number3")]);
+
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number4")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number4")]);

[Ilya Sherman, 2014/08/12 04:23:42]

Please also verify that the start indices are set correctly.

[Pritam Nikam, 2014/08/12 14:00:38]

Done.

+
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("month5")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_EXP_MONTH, field_type_map_[ASCIIToUTF16("month5")]);
+  ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("year6")) !=
+              field_type_map_.end());
+  EXPECT_EQ(CREDIT_CARD_EXP_4_DIGIT_YEAR,
+            field_type_map_[ASCIIToUTF16("year6")]);
+}
 }  // namespace autofill