[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/credit_card.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 
 #include <iosfwd>
 #include <string>
 #include <vector>
@@ skipping 94 matching lines @@
   bool IsEmpty(const std::string& app_locale) const;
 
   // Returns true if all field types have valid values set.
   bool IsComplete() const;
 
   // Returns true if all field types have valid values set and the card is not
   // expired.
   bool IsValid() const;
 
   // Returns the credit card number.
-  const base::string16& number() const { return number_; }
+  base::string16 GetNumber() const;
 
  private:
   // FormGroup:
   virtual void GetSupportedTypes(
       ServerFieldTypeSet* supported_types) const OVERRIDE;
 
   // The month and year are zero if not present.
   int Expiration4DigitYear() const { return expiration_year_; }
   int Expiration2DigitYear() const { return expiration_year_ % 100; }
   base::string16 ExpirationMonthAsString() const;
   base::string16 Expiration4DigitYearAsString() const;
   base::string16 Expiration2DigitYearAsString() const;
 
   // Sets |expiration_month_| to the integer conversion of |text|.
   void SetExpirationMonthFromString(const base::string16& text,
                                     const std::string& app_locale);
 
   // Sets |expiration_year_| to the integer conversion of |text|.
   void SetExpirationYearFromString(const base::string16& text);
 
+  enum Part { first_part, second_part, third_part, last_part, full_number };
+
   // Sets |number_| to |number| and computes the appropriate card |type_|.
-  void SetNumber(const base::string16& number);
+  void SetNumber(const base::string16& number,
+                 const Part& part = autofill::CreditCard::full_number);
 
   // These setters verify that the month and year are within appropriate
   // ranges.
   void SetExpirationMonth(int expiration_month);
   void SetExpirationYear(int expiration_year);
 
-  base::string16 number_;  // The credit card number.
+  base::string16 number_part1_;  // The credit card number part 1 (0-3).
+  base::string16 number_part2_;  // The credit card number part 2 (4-7).
+  base::string16 number_part3_;  // The credit card number part 3 (8-12).
+  base::string16 number_part4_;  // The credit card number part 4 (12-End).

[Ilya Sherman, 2014/07/25 03:37:49]

These shouldn't be necessary.  The card number should still be stored as a
single unit, and dynamically split into substrings as needed.

[Pritam Nikam, 2014/07/26 11:29:50]

Done.

   base::string16 name_on_card_;  // The cardholder's name.
   std::string type_;  // The type of the card.
 
   // These members are zero if not present.
   int expiration_month_;
   int expiration_year_;
 };
 
 // So we can compare CreditCards with EXPECT_EQ().
 std::ostream& operator<<(std::ostream& os, const CreditCard& credit_card);
 
 // The string identifiers for credit card icon resources.
 extern const char* const kAmericanExpressCard;
 extern const char* const kDinersCard;
 extern const char* const kDiscoverCard;
 extern const char* const kGenericCard;
 extern const char* const kJCBCard;
 extern const char* const kMasterCard;
 extern const char* const kUnionPay;
 extern const char* const kVisaCard;
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_