components/autofill/core/browser/phone_field.h - Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/phone_field.h

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/core/browser/name_field_unittest.cc ('k') | components/autofill/core/browser/phone_field.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_

6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76	76

77 static const Parser kPhoneFieldGrammars[];	77 static const Parser kPhoneFieldGrammars[];

78	78

79 PhoneField();	79 PhoneField();

80	80

81 // Returns the regular expression string correspoding to \|regex_id\|	81 // Returns the regular expression string correspoding to \|regex_id\|

82 static base::string16 GetRegExp(RegexType regex_id);	82 static base::string16 GetRegExp(RegexType regex_id);

83	83

84 // FIELD_PHONE is always present; holds suffix if prefix is present.	84 // FIELD_PHONE is always present; holds suffix if prefix is present.

85 // The rest could be NULL.	85 // The rest could be NULL.

86 const AutofillField* parsed_phone_fields_[FIELD_MAX];	86 AutofillField* parsed_phone_fields_[FIELD_MAX];

87	87

88 DISALLOW_COPY_AND_ASSIGN(PhoneField);	88 DISALLOW_COPY_AND_ASSIGN(PhoneField);

89 };	89 };

90	90

91 } // namespace autofill	91 } // namespace autofill

92	92

93 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_	93 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PHONE_FIELD_H_

OLD	NEW