[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/autofill_field_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_field.h"
 
 #include "base/format_macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 16 matching lines @@
     options16[i] = ASCIIToUTF16(options[i]);
   }
 
   FormFieldData form_field;
   form_field.form_control_type = "select-one";
   form_field.option_values = options16;
   form_field.option_contents = options16;
   return form_field;
 }
 
+struct TestCase {
+  std::string card_number_;
+  size_t total_spilts_;
+  std::vector<int> splits_;
+  std::vector<std::string> expected_results_;
+};
+
+// Returns the offset to be set within the credit card number field.
+size_t GetNumberOffset(size_t index, TestCase test) {

[Ilya Sherman, 2014/09/03 01:07:51]

nit: Please pass by const reference.

[Pritam Nikam, 2014/09/03 12:21:50]

Done.

+  size_t ret = 0;

[Ilya Sherman, 2014/09/03 01:07:51]

nit: "ret" -> "result"

[Pritam Nikam, 2014/09/03 12:21:50]

Done.

+  for (size_t i = 0; i < index; ++i)
+    ret += test.splits_[i];
+  return ret;
+}
+
 TEST(AutofillFieldTest, Type) {
   AutofillField field;
   ASSERT_EQ(NO_SERVER_DATA, field.server_type());
   ASSERT_EQ(UNKNOWN_TYPE, field.heuristic_type());
 
   // |server_type_| is NO_SERVER_DATA, so |heuristic_type_| is returned.
   EXPECT_EQ(UNKNOWN_TYPE, field.Type().GetStorableType());
 
   // Set the heuristic type and check it.
   field.set_heuristic_type(NAME_FIRST);
@@ skipping 449 matching lines @@
 
   AutofillField::FillFormField(field,
                                UTF8ToUTF16("桜丘町26-1\n"
                                            "セルリアンタワー6階"),
                                "ja-JP",
                                "en-US",
                                &field);
   EXPECT_EQ(UTF8ToUTF16("桜丘町26-1セルリアンタワー6階"), field.value);
 }
 
+TEST(AutofillFieldTest, FillCreditCardNumberWithoutSplits) {
+  // Case 1: card number without any spilt.
+  AutofillField cc_number_full;
+  cc_number_full.set_heuristic_type(CREDIT_CARD_NUMBER);
+  AutofillField::FillFormField(cc_number_full,
+                               ASCIIToUTF16("4111111111111111"),
+                               "en-US",
+                               "en-US",
+                               &cc_number_full);
+
+  // Verify that full card-number shall get fill properly.
+  EXPECT_EQ(ASCIIToUTF16("4111111111111111"), cc_number_full.value);
+  EXPECT_EQ(0U, cc_number_full.credit_card_number_offset());
+}
+
+TEST(AutofillFieldTest, FillCreditCardNumberWithEqualSizeSplits) {
+  // Case 2: card number broken up into four equal groups, of length 4.
+  TestCase test;
+  test.card_number_ = "5187654321098765";
+  test.total_spilts_ = 4;
+  int splits[] = {4, 4, 4, 4};
+  test.splits_ = std::vector<int>(splits, splits + arraysize(splits));
+  std::string results[] = {"5187654321098765", "654321098765", "21098765",
+                           "8765"};
+  test.expected_results_ =
+      std::vector<std::string>(results, results + arraysize(results));
+
+  for (size_t i = 0; i < test.total_spilts_; ++i) {
+    AutofillField cc_number_part;
+    cc_number_part.set_heuristic_type(CREDIT_CARD_NUMBER);
+    cc_number_part.max_length = test.splits_[i];
+    cc_number_part.set_credit_card_number_offset(4 * i);
+
+    // Fill with a card-number; should fill just the card_number_part.
+    AutofillField::FillFormField(cc_number_part,
+                                 ASCIIToUTF16(test.card_number_),
+                                 "en-US",
+                                 "en-US",
+                                 &cc_number_part);
+
+    // Verify for expected results.
+    EXPECT_EQ(ASCIIToUTF16(test.expected_results_[i]), cc_number_part.value);
+    EXPECT_EQ(4 * i, cc_number_part.credit_card_number_offset());
+  }
+
+  // Verify that full card-number shall get fill properly as well.
+  AutofillField cc_number_full;
+  cc_number_full.set_heuristic_type(CREDIT_CARD_NUMBER);
+  AutofillField::FillFormField(cc_number_full,
+                               ASCIIToUTF16(test.card_number_),
+                               "en-US",
+                               "en-US",
+                               &cc_number_full);
+
+  // Verify for expected results.
+  EXPECT_EQ(ASCIIToUTF16(test.card_number_), cc_number_full.value);
+}
+
+TEST(AutofillFieldTest, FillCreditCardNumberWithUnequalSizeSplits) {
+  // Case 3: card with 15 digits number, broken up into three unequal groups, of
+  // lengths 4, 6, and 5.
+  TestCase test;
+  test.card_number_ = "423456789012345";
+  test.total_spilts_ = 3;
+  int splits[] = {4, 6, 5};
+  test.splits_ = std::vector<int>(splits, splits + arraysize(splits));
+  std::string results[] = {"423456789012345", "56789012345", "12345"};

[Ilya Sherman, 2014/09/03 01:07:51]

These values do not make sense to me.  Shouldn't they be "4234", "567890",
"12345"?  I see that you set max_length below.  Is it not being respected?  The
value visible to JavaScript should not be different from the value visible to
the user; so if the max_length doesn't actually automatically trim the set
values, then we should do so manually.

[Pritam Nikam, 2014/09/03 12:21:50]

Done.

We leave the field will enforce max_length on its own and avoid truncating
explicitly. And hence we just adjust start index (or an offset) within the
number sub-string.

[Ilya Sherman, 2014/09/03 23:25:26]

Have you verified that the max_length is enforced on the renderer side both for
the value that's visible to the user and for the value that's visible to
JavaScript (document.getElementById('theElementId').value)?

+  test.expected_results_ =
+      std::vector<std::string>(results, results + arraysize(results));
+
+  // Start executing test cases to verify parts and full credit card number.
+  for (size_t i = 0; i < test.total_spilts_; ++i) {
+    AutofillField cc_number_part;
+    cc_number_part.set_heuristic_type(CREDIT_CARD_NUMBER);
+    cc_number_part.max_length = test.splits_[i];
+    cc_number_part.set_credit_card_number_offset(GetNumberOffset(i, test));
+
+    // Fill with a card-number; should fill just the card_number_part.
+    AutofillField::FillFormField(cc_number_part,
+                                 ASCIIToUTF16(test.card_number_),
+                                 "en-US",
+                                 "en-US",
+                                 &cc_number_part);
+
+    // Verify for expected results.
+    EXPECT_EQ(ASCIIToUTF16(test.expected_results_[i]), cc_number_part.value);
+    EXPECT_EQ(GetNumberOffset(i, test),
+              cc_number_part.credit_card_number_offset());
+  }
+
+  // Verify that full card-number shall get fill properly as well.
+  AutofillField cc_number_full;
+  cc_number_full.set_heuristic_type(CREDIT_CARD_NUMBER);
+  AutofillField::FillFormField(cc_number_full,
+                               ASCIIToUTF16(test.card_number_),
+                               "en-US",
+                               "en-US",
+                               &cc_number_full);
+
+  // Verify for expected results.
+  EXPECT_EQ(ASCIIToUTF16(test.card_number_), cc_number_full.value);
+}
+
 }  // namespace
 }  // namespace autofill