[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/credit_card_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card_field.h"
 
 #include <stddef.h>

[Ilya Sherman, 2014/08/12 04:23:42]

nit: Please include a blank line after this one, to separate the C header
includes from the C++ ones.

[Pritam Nikam, 2014/08/12 14:00:37]

Done.

+#include <algorithm>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_regex_constants.h"
 #include "components/autofill/core/browser/autofill_scanner.h"
 #include "components/autofill/core/browser/field_types.h"
@@ skipping 64 matching lines @@
     // has a plethora of names; we've seen "verification #",
     // "verification number", "card identification number" and others listed
     // in the |pattern| below.
     base::string16 pattern = base::UTF8ToUTF16(autofill::kCardCvcRe);
     if (!credit_card_field->verification_ &&
         ParseField(scanner, pattern, &credit_card_field->verification_)) {
       continue;
     }
 
     pattern = base::UTF8ToUTF16(autofill::kCardNumberRe);
-    if (!credit_card_field->number_ &&
-        ParseField(scanner, pattern, &credit_card_field->number_)) {
+    const AutofillField* cc_number_field;
+    if (ParseField(scanner, pattern, &cc_number_field)) {
+      size_t start_index = 0;
+      AutofillField* current_number_field =
+          const_cast<AutofillField*>(cc_number_field);

[Pritam Nikam, 2014/08/12 14:00:38]

I didn't get any alternative approach to fix const_cast<> used here.

Changing ParseField() signature will have lots of signature changes as its just
a wrapper API. And may be doing that will have ripple effect across [form-field,
scanner and cursor modules].

I'm kind of blocked here, please guide me how can I solve this problem.

+      // Avoid having very large start_index.
+      if (!credit_card_field->numbers_.empty())
+        start_index =
+            std::min(std::numeric_limits<size_t>::max(),

[Ilya Sherman, 2014/08/12 04:23:42]

This std::min call does not do anything, since the max size_t value is by
definitely the largest possible value, so std::min will always pick the other
option (or possibly both, if the two inputs are equal).

[Pritam Nikam, 2014/08/12 14:00:37]

Done.

+                     credit_card_field->numbers_.back()
+                             ->credit_card_number_start_index() +
+                         credit_card_field->numbers_.back()->max_length);

[Ilya Sherman, 2014/08/12 04:23:42]

You should probably check whether the resulting start_index + max_length for the
last field is a small value (say, less than or equal to 19, which according to [
https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...
] is the maximum length of a credit card number).  At the least, you should
check whether the max_length is the default (very large) value, or something
smaller.  If we see four fields in a row that don't have a max_length set, we
should probably bail on parsing the form.

[Pritam Nikam, 2014/08/12 14:00:37]

Done.

+
+      current_number_field->set_credit_card_number_start_index(start_index);
+      credit_card_field->numbers_.push_back(current_number_field);
       continue;
     }
 
     if (LowerCaseEqualsASCII(scanner->Cursor()->form_control_type, "month")) {
       credit_card_field->expiration_date_ = scanner->Cursor();
       scanner->Advance();
     } else {
       // First try to parse split month/year expiration fields.
       scanner->SaveCursor();
       pattern = base::UTF8ToUTF16(autofill::kExpirationMonthRe);
@@ skipping 56 matching lines @@
   if (credit_card_field->cardholder_)
     return credit_card_field.release();
 
   // On some pages, the user selects a card type using radio buttons
   // (e.g. test page Apple Store Billing.html).  We can't handle that yet,
   // so we treat the card type as optional for now.
   // The existence of a number or cvc in combination with expiration date is
   // a strong enough signal that this is a credit card.  It is possible that
   // the number and name were parsed in a separate part of the form.  So if
   // the cvc and date were found independently they are returned.
-  if ((credit_card_field->number_ || credit_card_field->verification_) &&
+  if ((!credit_card_field->numbers_.empty() ||
+       credit_card_field->verification_) &&
       (credit_card_field->expiration_date_ ||
        (credit_card_field->expiration_month_ &&
         credit_card_field->expiration_year_))) {
     return credit_card_field.release();
   }
 
   scanner->RewindTo(saved_cursor);
   return NULL;
 }
 
 CreditCardField::CreditCardField()
     : cardholder_(NULL),
       cardholder_last_(NULL),
       type_(NULL),
-      number_(NULL),
       verification_(NULL),
       expiration_month_(NULL),
       expiration_year_(NULL),
       expiration_date_(NULL),
       is_two_digit_year_(false) {
 }
 
+CreditCardField::~CreditCardField() {
+}
+
 bool CreditCardField::ClassifyField(ServerFieldTypeMap* map) const {
-  bool ok = AddClassification(number_, CREDIT_CARD_NUMBER, map);
+  bool ok = true;
+  for (std::vector<const AutofillField*>::const_iterator it = numbers_.begin();
+       it != numbers_.end();
+       ++it)
+    ok = ok && AddClassification(*it, CREDIT_CARD_NUMBER, map);

[Ilya Sherman, 2014/08/12 04:23:42]

nit: Please add curly braces.

[Pritam Nikam, 2014/08/12 14:00:37]

Done.

+
   ok = ok && AddClassification(type_, CREDIT_CARD_TYPE, map);
   ok = ok && AddClassification(verification_, CREDIT_CARD_VERIFICATION_CODE,
                                map);
 
   // If the heuristics detected first and last name in separate fields,
   // then ignore both fields. Putting them into separate fields is probably
   // wrong, because the credit card can also contain a middle name or middle
   // initial.
   if (cardholder_last_ == NULL)
     ok = ok && AddClassification(cardholder_, CREDIT_CARD_NAME, map);
@@ skipping 16 matching lines @@
       ok = ok && AddClassification(expiration_year_,
                                    CREDIT_CARD_EXP_4_DIGIT_YEAR,
                                    map);
     }
   }
 
   return ok;
 }
 
 }  // namespace autofill