[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/autofill_field.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/common/form_field_data.h"
 
 namespace autofill {
 
 class AutofillType;
 
 class AutofillField : public FormFieldData {
  public:
   enum PhonePart {
     IGNORED = 0,
     PHONE_PREFIX = 1,
     PHONE_SUFFIX = 2,
   };
 
+  // This structure holds the credit card number split information on the html
+  // form structure.
+  struct CreditCardNumberInfo {
+    int part_;
+    int start_index_;

[Ilya Sherman, 2014/08/07 20:57:25]

Why do you need the part in addition to the index?

[Pritam Nikam, 2014/08/08 14:14:34]

Done.
Removed this structure and instead book-keeping the start_index only.

+  };
+
   AutofillField();
   AutofillField(const FormFieldData& field, const base::string16& unique_name);
   virtual ~AutofillField();
 
   const base::string16& unique_name() const { return unique_name_; }
 
   const std::string& section() const { return section_; }
   ServerFieldType heuristic_type() const { return heuristic_type_; }
   ServerFieldType server_type() const { return server_type_; }
   HtmlFieldType html_type() const { return html_type_; }
@@ skipping 21 matching lines @@
   // input type in a 32-bit hash.
   std::string FieldSignature() const;
 
   // Returns true if the field type has been determined (without the text in the
   // field).
   bool IsFieldFillable() const;
 
   void set_default_value(const std::string& value) { default_value_ = value; }
   const std::string& default_value() const { return default_value_; }
 
+  void set_credit_card_number_info(CreditCardNumberInfo* card_number_info) {
+    credit_card_number_info_ = card_number_info;
+  }
+  CreditCardNumberInfo* credit_card_number_info() const {
+    return credit_card_number_info_;
+  }
+
   // Set |field_data|'s value to |value|. Uses |field|, |address_language_code|,
   // and |app_locale| as hints when filling exceptional cases like phone number
   // values and <select> fields. Returns |true| if the field has been filled,
   // |false| otherwise.
   static bool FillFormField(const AutofillField& field,
                             const base::string16& value,
                             const std::string& address_language_code,
                             const std::string& app_locale,
                             FormFieldData* field_data);
 
@@ skipping 17 matching lines @@
   // The "mode" of the field, as specified by the site author in HTML.
   // Currently this is used to distinguish between billing and shipping fields.
   HtmlFieldMode html_mode_;
 
   // The set of possible types for this field.
   ServerFieldTypeSet possible_types_;
 
   // Used to track whether this field is a phone prefix or suffix.
   PhonePart phone_part_;
 
+  // Used to track whether this field is a credit card number along with split
+  // information.
+  CreditCardNumberInfo* credit_card_number_info_;
+
   // The default value returned by the Autofill server.
   std::string default_value_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillField);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_