Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 381613003: Parser / Scanner: Minor refactorings to make streaming scripts work easier. (Closed)

Created:
6 years, 5 months ago by marja
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Parser / Scanner: Minor refactorings to make streaming scripts work easier. 1) Call DeserializeScopeChain only if it's going to do something non-trivial. And we only need to internalize the AstValueFactory in those cases. 2) BufferedUtf16CharacterStream::FillBuffer doesn't need the length argument. The length is always kBufferSize and the subclasses can just read it (it's protected). R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scanner-character-streams.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/scanner-character-streams.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
rossberg, ptal
6 years, 5 months ago (2014-07-09 13:38:05 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-09 14:12:59 UTC) #2
marja
6 years, 5 months ago (2014-07-09 14:50:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698