Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 381613002: Add UseCounter for flex items having intinsic aspect ratios (Closed)

Created:
6 years, 5 months ago by harpreet.sk
Modified:
6 years, 5 months ago
CC:
blink-reviews, cbiesinger, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add UseCounter for flex items having intinsic aspect ratios According to flexbox spec http://dev.w3.org/csswg/css-flexbox/#algo-main-item we should take intrinsic aspect ratios into account during main-size calculation. Currently none of the browser is taking aspect ratio into account while calculating main-size of flexbox. Adding a use counter to determine how common it is for a flex item to have intrinsic aspect ratios. BUG=249112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
harpreet.sk
PTAL... This CL has been added as per comment#9 in https://codereview.chromium.org/343103003/ to determine how common ...
6 years, 5 months ago (2014-07-09 12:03:26 UTC) #1
tony
I'm not an OWNER of this code, but LGTM. This will do a bit of ...
6 years, 5 months ago (2014-07-09 16:16:51 UTC) #2
harpreet.sk
@leviw can you please give lgtm
6 years, 5 months ago (2014-07-10 06:53:03 UTC) #3
harpreet.sk
Owners please give lgtm
6 years, 5 months ago (2014-07-11 16:47:53 UTC) #4
eseidel
lgtm
6 years, 5 months ago (2014-07-11 19:45:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/381613002/1
6 years, 5 months ago (2014-07-11 19:47:24 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-11 20:57:30 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 21:29:20 UTC) #8
Message was sent while issue was closed.
Change committed as 177981

Powered by Google App Engine
This is Rietveld 408576698