Address comments on double-parse implementation from earlier CL.

runtime/lib/string_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class String {
   /* patch */ factory String.fromCharCodes(Iterable<int> charCodes) {
     return _StringBase.createFromCharCodes(charCodes);
   }
 
   /* patch */ factory String.fromCharCode(int charCode) {
@@ skipping 115 matching lines @@
       }
     }
     return true;
   }
 
   int compareTo(String other) {
     int thisLength = this.length;
     int otherLength = other.length;
     int len = (thisLength < otherLength) ? thisLength : otherLength;
     for (int i = 0; i < len; i++) {
-      int thisCodePoint = this.codeUnitAt(i);
-      int otherCodePoint = other.codeUnitAt(i);
-      if (thisCodePoint < otherCodePoint) {
+      int thisCodeUnit = this.codeUnitAt(i);
+      int otherCodeUnit = other.codeUnitAt(i);
+      if (thisCodeUnit < otherCodeUnit) {
         return -1;
       }
-      if (thisCodePoint > otherCodePoint) {
+      if (thisCodeUnit > otherCodeUnit) {
         return 1;
       }
     }
     if (thisLength < otherLength) return -1;
     if (thisLength > otherLength) return 1;
     return 0;
   }
 
   bool _substringMatches(int start, String other) {
     if (other.isEmpty) return true;
@@ skipping 121 matching lines @@
   // 1680          ; White_Space # Zs       OGHAM SPACE MARK
   // 180E          ; White_Space # Zs       MONGOLIAN VOWEL SEPARATOR
   // 2000..200A    ; White_Space # Zs       EN QUAD..HAIR SPACE
   // 2028          ; White_Space # Zl       LINE SEPARATOR
   // 2029          ; White_Space # Zp       PARAGRAPH SEPARATOR
   // 202F          ; White_Space # Zs       NARROW NO-BREAK SPACE
   // 205F          ; White_Space # Zs       MEDIUM MATHEMATICAL SPACE
   // 3000          ; White_Space # Zs       IDEOGRAPHIC SPACE
   //
   // BOM: 0xFEFF
-  static bool _isTwoByteWhitespace(int codePoint) {
-    if (codePoint < 256) return _isOneByteWhitespace(codePoint);
-    return (codePoint == 0x1680) ||
-        (codePoint == 0x180E) ||
-        ((0x2000 <= codePoint) && (codePoint <= 0x200A)) ||
-        (codePoint == 0x2028) ||
-        (codePoint == 0x2029) ||
-        (codePoint == 0x202F) ||
-        (codePoint == 0x205F) ||
-        (codePoint == 0x3000) ||
-        (codePoint == 0xFEFF);
+  static bool _isTwoByteWhitespace(int codeUnit) {
+    if (codeUnit < 256) return _isOneByteWhitespace(codeUnit);
+    return (codeUnit == 0x1680) ||
+        (codeUnit == 0x180E) ||
+        ((0x2000 <= codeUnit) && (codeUnit <= 0x200A)) ||
+        (codeUnit == 0x2028) ||
+        (codeUnit == 0x2029) ||
+        (codeUnit == 0x202F) ||
+        (codeUnit == 0x205F) ||
+        (codeUnit == 0x3000) ||
+        (codeUnit == 0xFEFF);
   }
 
   int _firstNonWhitespace() {
     final len = this.length;
     int first = 0;
     for (; first < len; first++) {
       if (!_isWhitespace(this.codeUnitAt(first))) {
         break;
       }
     }
@@ skipping 332 matching lines @@
 
 class _OneByteString extends _StringBase implements String {
 
   factory _OneByteString._uninstantiable() {
     throw new UnsupportedError(
         "_OneByteString can only be allocated by the VM");
   }
 
   int get hashCode native "String_getHashCode";
 
-  bool _isWhitespace(int codePoint) {
-    return _StringBase._isOneByteWhitespace(codePoint);
+  bool _isWhitespace(int codeUnit) {
+    return _StringBase._isOneByteWhitespace(codeUnit);
   }
 
   bool operator ==(Object other) {
     return super == other;
   }
 
   String _substringUncheckedNative(int startIndex, int endIndex)
       native "OneByteString_substringUnchecked";
 
   List<String> _splitWithCharCode(int charCode)
@@ skipping 256 matching lines @@
   void _setAt(int index, int codePoint) native "OneByteString_setAt";
 }
 
 
 class _TwoByteString extends _StringBase implements String {
   factory _TwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_TwoByteString can only be allocated by the VM");
   }
 
-  bool _isWhitespace(int codePoint) {
-    return _StringBase._isTwoByteWhitespace(codePoint);
+  bool _isWhitespace(int codeUnit) {
+    return _StringBase._isTwoByteWhitespace(codeUnit);
   }
 
   bool operator ==(Object other) {
     return super == other;
   }
 }
 
 
 class _ExternalOneByteString extends _StringBase implements String {
   factory _ExternalOneByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalOneByteString can only be allocated by the VM");
   }
 
-  bool _isWhitespace(int codePoint) {
-    return _StringBase._isOneByteWhitespace(codePoint);
+  bool _isWhitespace(int codeUnit) {
+    return _StringBase._isOneByteWhitespace(codeUnit);
   }
 
   bool operator ==(Object other) {
     return super == other;
   }
 
   static int _getCid() native "ExternalOneByteString_getCid";
 }
 
 
 class _ExternalTwoByteString extends _StringBase implements String {
   factory _ExternalTwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalTwoByteString can only be allocated by the VM");
   }
 
-  bool _isWhitespace(int codePoint) {
-    return _StringBase._isTwoByteWhitespace(codePoint);
+  bool _isWhitespace(int codeUnit) {
+    return _StringBase._isTwoByteWhitespace(codeUnit);
   }
 
   bool operator ==(Object other) {
     return super == other;
   }
 }
 
 
 class _StringMatch implements Match {
   const _StringMatch(int this.start,
@@ skipping 30 matching lines @@
 class _CodeUnits extends Object with ListMixin<int>,
                                      UnmodifiableListMixin<int> {
   /** The string that this is the code units of. */
   String _string;
 
   _CodeUnits(this._string);
 
   int get length => _string.length;
   int operator[](int i) => _string.codeUnitAt(i);
 }