Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 381473006: Clean up static_cast<const toBasicFoo*> by using toBasicFoo() (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up static_cast<const toBasicShapeFoo*> by using toBasicShapeFoo() Removed remained static_cast<const toBasicShapeFoo*>. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M Source/core/rendering/shapes/Shape.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.cpp View 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-09 07:42:21 UTC) #1
gyuyoung-inactive
6 years, 5 months ago (2014-07-10 01:33:48 UTC) #2
tkent
On 2014/07/10 01:33:48, gyuyoung wrote: lgtm > Clean up static_cast<const toBasicFoo*> by using toBasicFoo() toBasicShapeFoo ...
6 years, 5 months ago (2014-07-10 02:33:11 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-10 02:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/381473006/1
6 years, 5 months ago (2014-07-10 02:34:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-10 03:43:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 04:49:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/15689)
6 years, 5 months ago (2014-07-10 04:49:50 UTC) #8
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-10 04:53:58 UTC) #9
gyuyoung-inactive
On 2014/07/10 04:49:50, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-10 04:54:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/381473006/1
6 years, 5 months ago (2014-07-10 04:55:01 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-10 06:00:24 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 07:03:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/15708)
6 years, 5 months ago (2014-07-10 07:04:00 UTC) #14
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-10 07:04:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/381473006/1
6 years, 5 months ago (2014-07-10 07:05:21 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:16:40 UTC) #17
Message was sent while issue was closed.
Change committed as 177811

Powered by Google App Engine
This is Rietveld 408576698