Modifications to print preview so that a browser test can communicate with the dialog.

Set up message passing between C++ and JavaScript for end-to-end testing of print preview. Allows preview settings, such as the page range, to be set during a browser test.

BUG=388517
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283669

[Aleksey Shlyapnikov, 2014-07-09 01:45:07]

https://codereview.chromium.org/381453003/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/native_layer.js (left):

https://codereview.chromium.org/381453003/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/native_layer.js:187: /**
Please bring this and related code back.

https://codereview.chromium.org/381453003/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/381453003/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:925: if
(print_preview.Destination.GooglePromotedId.SAVE_AS_PDF ==
Check that this.destinationStore_.selectedDestination != null first.

https://codereview.chromium.org/381453003/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:926:
this.destinationStore_.selectedDestination.id) {
2 less spaces indent.

[Lei Zhang, 2014-07-09 02:13:33]

Again, please change the CL description to what this CL actually does. What you
have currently does not make sense as a commit message to anyone but us.

[ivandavid, 2014-07-10 01:15:57]

I restored the old code and added the period.

[Dan Beam, 2014-07-10 02:28:32]

lgtm w/better commit message

my recommendation (don't need to take it, thestig@ will likely have a better
one):

Set up message passing between C++ and JavaScript to end-to-end test print
preview.

https://codereview.chromium.org/381453003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/381453003/diff/40001/chrome/browser/resources...
chrome/browser/resources/print_preview/print_preview.js:925: if
(this.destinationStore_.selectedDestination != null &&
nit: when possible, don't compare to null, e.g.

  if (this.destinationStore_.selectedDestination &&

[Aleksey Shlyapnikov, 2014-07-10 04:35:47]

lgtm

[ivandavid, 2014-07-16 22:21:51]

The CQ bit was checked by ivandavid@chromium.org

[commit-bot: I haz the power, 2014-07-16 22:24:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ivandavid@chromium.org/381453003/60001

[commit-bot: I haz the power, 2014-07-17 03:16:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-17 03:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 03:51:17]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Lei Zhang, 2014-07-17 03:55:46]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-17 03:58:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ivandavid@chromium.org/381453003/60001

[commit-bot: I haz the power, 2014-07-17 06:47:11]

Change committed as 283669