Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: Source/core/dom/ExecutionContext.h

Issue 38143002: Have LifecycleContext::lifecycleNotifier() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2012 Google Inc. All Rights Reserved. 3 * Copyright (C) 2012 Google Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 int circularSequentialID(); 118 int circularSequentialID();
119 119
120 void didChangeTimerAlignmentInterval(); 120 void didChangeTimerAlignmentInterval();
121 121
122 SandboxFlags sandboxFlags() const { return m_sandboxFlags; } 122 SandboxFlags sandboxFlags() const { return m_sandboxFlags; }
123 bool isSandboxed(SandboxFlags mask) const { return m_sandboxFlags & mask; } 123 bool isSandboxed(SandboxFlags mask) const { return m_sandboxFlags & mask; }
124 void enforceSandboxFlags(SandboxFlags mask); 124 void enforceSandboxFlags(SandboxFlags mask);
125 125
126 protected: 126 protected:
127 127
128 ContextLifecycleNotifier* lifecycleNotifier(); 128 ContextLifecycleNotifier& lifecycleNotifier();
129 129
130 private: 130 private:
131 friend class DOMTimer; // For installNewTimeout() and removeTimeoutByID() be low. 131 friend class DOMTimer; // For installNewTimeout() and removeTimeoutByID() be low.
132 132
133 bool dispatchErrorEvent(PassRefPtr<ErrorEvent>, AccessControlStatus); 133 bool dispatchErrorEvent(PassRefPtr<ErrorEvent>, AccessControlStatus);
134 134
135 void closeMessagePorts(); 135 void closeMessagePorts();
136 136
137 virtual void refExecutionContext() = 0; 137 virtual void refExecutionContext() = 0;
138 virtual void derefExecutionContext() = 0; 138 virtual void derefExecutionContext() = 0;
(...skipping 23 matching lines...) Expand all
162 162
163 // The location of this member is important; to make sure contextDestroyed() notification on 163 // The location of this member is important; to make sure contextDestroyed() notification on
164 // ExecutionContext's members (notably m_timeouts) is called before they are destructed, 164 // ExecutionContext's members (notably m_timeouts) is called before they are destructed,
165 // m_lifecycleNotifer should be placed *after* such members. 165 // m_lifecycleNotifer should be placed *after* such members.
166 OwnPtr<ContextLifecycleNotifier> m_lifecycleNotifier; 166 OwnPtr<ContextLifecycleNotifier> m_lifecycleNotifier;
167 }; 167 };
168 168
169 } // namespace WebCore 169 } // namespace WebCore
170 170
171 #endif // ExecutionContext_h 171 #endif // ExecutionContext_h
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698