Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 38143002: Have LifecycleContext::lifecycleNotifier() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have LifecycleContext::lifecycleNotifier() return a reference Have LifecycleContext::lifecycleNotifier() return a reference instead of a pointer as it can never return null. This makes the calling code look safer. R=adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160456

Patch Set 1 #

Patch Set 2 : No Change #

Patch Set 3 : No Change #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M Source/core/dom/Document.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/Page.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/LifecycleContext.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
7 years, 2 months ago (2013-10-23 21:40:15 UTC) #1
adamk
Handing off to morrita, as I'm not sure exactly where all this Lifecycle stuff is ...
7 years, 2 months ago (2013-10-23 21:49:32 UTC) #2
Hajime Morrita
LGTM. This is fine. Please update the patch. I just landed one that conflicts with ...
7 years, 2 months ago (2013-10-24 04:16:42 UTC) #3
Hajime Morrita
LTGM. This is fine. Please update the patch to ToT. I just landed one that ...
7 years, 2 months ago (2013-10-24 04:17:52 UTC) #4
Hajime Morrita
Hmm. for some reason I cannot comment on this issue.
7 years, 2 months ago (2013-10-24 04:18:19 UTC) #5
Hajime Morrita
LTGM. This is fine. Please update the patch to ToT. I just landed one that ...
7 years, 2 months ago (2013-10-24 04:18:47 UTC) #6
Hajime Morrita
Ooops. Something wrong is happening ... Sorry for the noise.
7 years, 2 months ago (2013-10-24 04:19:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/38143002/130001
7 years, 2 months ago (2013-10-24 14:22:12 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-10-24 15:37:13 UTC) #9
Message was sent while issue was closed.
Change committed as 160456

Powered by Google App Engine
This is Rietveld 408576698