Issue 381413002: Remove unnecessary scoped_ptr in password_form_manager_unittest.cc (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381413002: Remove unnecessary scoped_ptr in password_form_manager_unittest.cc (Part 2) (Closed)

Created:
6 years, 5 months ago by lucinka.brozkova

Modified:
6 years, 5 months ago

Reviewers:
vabr (Chromium), vasilii

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, engedy

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove unnecessary scoped_ptr in password_form_manager_unittest.cc (Part 2) Simple test code refactoring, no behaviour change. Part 1: https://codereview.chromium.org/371743002/ BUG=391487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282623

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -65 lines)			Patch
	M	components/password_manager/core/browser/password_form_manager_unittest.cc	View		5 chunks	+63 lines, -65 lines	0 comments	Download

Total messages: 7 (0 generated)

vabr (Chromium)

LGTM, Thanks. (Because it is still one of your first CLs, please get another review, ...

6 years, 5 months ago (2014-07-11 09:53:02 UTC) #1

lucinka.brozkova

Hi Balázs, PTAL, this is the second part of https://codereview.chromium.org/371743002/ Cheers, Lucie

6 years, 5 months ago (2014-07-11 10:57:45 UTC) #2

vabr (Chromium)

Since Balázs is a little flooded by reviews from our family, Vasilii agreed to do ...

6 years, 5 months ago (2014-07-11 11:25:09 UTC) #3

lucinka.brozkova

The CQ bit was checked by lucinka.brozkova@gmail.com

6 years, 5 months ago (2014-07-11 11:59:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lucinka.brozkova@gmail.com/381413002/1

6 years, 5 months ago (2014-07-11 12:00:25 UTC) #6

Message was sent while issue was closed.

Change committed as 282623