Issue 381353005: Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381353005: Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and (Closed)

Created:
6 years, 5 months ago by Stephen White

Modified:
6 years, 5 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and "resizeimagefiler is ok with a BBH now". This reverts commits 6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de and 8fa73202eaffbd7591ee218ad452b9afde81f505. Apparently causing problems in SKP playback. TBR=robertphillips,mtklein BUG=skia: Committed: https://skia.googlesource.com/skia/+/c07e2811dd8f15722ebdd1ff0a7f5449258569f1

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -110 lines)			Patch
M	gm/resizeimagefilter.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkBBoxRecord.h	View	4 chunks	+1 line, -11 lines	0 comments	Download
M	src/core/SkBBoxRecord.cpp	View	3 chunks	+0 lines, -35 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	1 chunk	+0 lines, -64 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/381353005/1

6 years, 5 months ago (2014-07-14 14:50:57 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-14 15:25:43 UTC) #3

Message was sent while issue was closed.

Change committed as c07e2811dd8f15722ebdd1ff0a7f5449258569f1

Expand Messages | Collapse Messages