fix broken translations for bookmarks.

fix broken translations for bookmarks.

Having the same name for a grd is bad because the post processor flattens
the file so one of them gets overriten with the other.

NOTRY=true
TBR=blundell
BUG=372175
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282495

[kareng, 2014-07-11 01:25:21]

lgtm

LGTM

[cpu_(ooo_6.6-7.5), 2014-07-11 01:26:12]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-07-11 01:27:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cpu@chromium.org/381353002/1

[commit-bot: I haz the power, 2014-07-11 01:38:06]

Change committed as 282495

[blundell, 2014-07-11 06:27:32]

I don't understand. Both bookmarks_strings files are grdp files that get
included in another grd file. Won't the post-processor operate on the level of
the expanded grd files, and not even see the grdp's as individual files at that
point?

[tfarina, 2014-07-11 17:46:57]

https://codereview.chromium.org/381353002/diff/1/components/bookmark_bar_stri...
File components/bookmark_bar_strings.grdp (right):

https://codereview.chromium.org/381353002/diff/1/components/bookmark_bar_stri...
components/bookmark_bar_strings.grdp:1: <?xml version="1.0" encoding="utf-8"?>
that my personal preference. If I were to name this file, then I would name it
components_bookmarks_strings.grdp, because if someone come later and add an
IDS_BOOKMRAK_FOO then it is not just bookmark bar strings.

[tfarina, 2014-07-11 17:48:27]

On 2014/07/11 06:27:32, blundell wrote:
> I don't understand. Both bookmarks_strings files are grdp files that get
> included in another grd file. Won't the post-processor operate on the level of
> the expanded grd files, and not even see the grdp's as individual files at
that
> point?

Yeah, I do also not know the details. +Tony for translation issues.

[tony, 2014-07-11 17:54:15]

I too am surprised that this works, but I don't know much about how <part>
expansion works (I've never looked at how it's implemented).  It's probably
worth filing a bug against grit that grdp file names have to be unique across
the whole project.

[tfarina, 2014-07-11 17:59:42]

On 2014/07/11 17:54:15, tony wrote:
> I too am surprised that this works, but I don't know much about how <part>
> expansion works (I've never looked at how it's implemented).  It's probably
> worth filing a bug against grit that grdp file names have to be unique across
> the whole project.

I have filed http://code.google.com/p/grit-i18n/issues/detail?id=29 for this.