chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h - Issue 381323002: [rough WIP] Make View::GetEventHandlerForRect() non-virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Issue 381323002: [rough WIP] Make View::GetEventHandlerForRect() non-virtual (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/decorated_textfield.cc ('k') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc » ('j') | ui/views/view_targeter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

index 6b805eae2ff345740124cfcacae9afa70e4aa62c..fd069381304452afc838de88a9fcd962187cf439 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

@@ -35,13 +35,13 @@ class BrowserNonClientFrameViewAsh

void Init();

- // BrowserNonClientFrameView overrides:

+ // BrowserNonClientFrameView:

virtual gfx::Rect GetBoundsForTabStrip(views::View* tabstrip) const OVERRIDE;

virtual int GetTopInset() const OVERRIDE;

virtual int GetThemeBackgroundXInset() const OVERRIDE;

virtual void UpdateThrobber(bool running) OVERRIDE;

- // views::NonClientFrameView overrides:

+ // views::NonClientFrameView:

virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;

virtual gfx::Rect GetWindowBoundsForClientBounds(

const gfx::Rect& client_bounds) const OVERRIDE;

@@ -51,12 +51,13 @@ class BrowserNonClientFrameViewAsh

virtual void ResetWindowControls() OVERRIDE;

virtual void UpdateWindowIcon() OVERRIDE;

virtual void UpdateWindowTitle() OVERRIDE;

+ virtual bool DoesIntersectRect(const views::View* target,

+ const gfx::Rect& rect) const OVERRIDE;

- // views::View overrides:

+ // views::View:

virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;

virtual void Layout() OVERRIDE;

virtual const char* GetClassName() const OVERRIDE;

- virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;

virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;

virtual gfx::Size GetMinimumSize() const OVERRIDE;

@@ -64,7 +65,7 @@ class BrowserNonClientFrameViewAsh

virtual void OnMaximizeModeStarted() OVERRIDE;

virtual void OnMaximizeModeEnded() OVERRIDE;

- // Overridden from chrome::TabIconViewModel:

+ // chrome::TabIconViewModel:

virtual bool ShouldTabIconViewAnimate() const OVERRIDE;

virtual gfx::ImageSkia GetFaviconForTabIconView() OVERRIDE;