Refactor code that defers extension background page loading

extensions/browser/process_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_PROCESS_MANAGER_H_
 #define EXTENSIONS_BROWSER_PROCESS_MANAGER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 107 matching lines @@
   void OnNetworkRequestStarted(content::RenderFrameHost* render_frame_host);
   void OnNetworkRequestDone(content::RenderFrameHost* render_frame_host);
 
   // Prevents |extension|'s background page from being closed and sends the
   // onSuspendCanceled() event to it.
   void CancelSuspend(const Extension* extension);
 
   // Ensures background hosts are loaded for a new browser window.
   void OnBrowserWindowReady();
 
+  // Notifies the ProcessManager that a BrowserContext is fully initialized.
+  // A BrowserContext might be initialized asynchronously (in parallel with
+  // extension system startup). The ProcessManager needs to know when that
+  // initialization is complete so it can load deferred background pages.
+  // (See NOTIFICATION_PROFILE_CREATED in Chrome and IsContextValid() in
+  // ExtensionsBrowserClient).
+  void OnBrowserContextValid(content::BrowserContext* context);
+
   // Gets the BrowserContext associated with site_instance_ and all other
   // related SiteInstances.
   content::BrowserContext* GetBrowserContext() const;
 
   // Sets callbacks for testing keepalive impulse behavior.
   typedef base::Callback<void(const std::string& extension_id)>
       ImpulseCallbackForTesting;
   void SetKeepaliveImpulseCallbackForTesting(
       const ImpulseCallbackForTesting& callback);
   void SetKeepaliveImpulseDecrementCallbackForTesting(
       const ImpulseCallbackForTesting& callback);
 
   // Creates an incognito-context instance for tests. Tests for non-incognito
   // contexts can just use Create() above.
   static ProcessManager* CreateIncognitoForTesting(
       content::BrowserContext* incognito_context,
       content::BrowserContext* original_context,
       ProcessManager* original_manager);
 
+  bool startup_background_hosts_created_for_test() const {
+    return startup_background_hosts_created_;
+  }
+
  protected:
   // If |context| is incognito pass the master context as |original_context|.
   // Otherwise pass the same context for both.
   ProcessManager(content::BrowserContext* context,
                  content::BrowserContext* original_context);
 
   // Called on browser shutdown to close our extension hosts.
   void CloseBackgroundHosts();
 
   // content::NotificationObserver:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
-  // Load all background pages once the profile data is ready and the pages
-  // should be loaded.
-  void CreateBackgroundHostsForProfileStartup();
+  // Loads all background pages for a BrowserContext if everything is ready.
+  void MaybeCreateBackgroundHostsForStartup();
 
   content::NotificationRegistrar registrar_;
 
   // The set of ExtensionHosts running viewless background extensions.
   ExtensionHostSet background_hosts_;
 
   // A SiteInstance related to the SiteInstance for all extensions in
   // this profile.  We create it in such a way that a new
   // browsing instance is created.  This controls process grouping.
   scoped_refptr<content::SiteInstance> site_instance_;
@@ skipping 73 matching lines @@
   ObserverList<ProcessManagerObserver> observer_list_;
 
   base::WeakPtrFactory<ProcessManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessManager);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_PROCESS_MANAGER_H_