Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 381133003: Add menu button to menu (Closed)

Created:
6 years, 5 months ago by David Trainor- moved to gerrit
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add menu button to menu To prepare for menus overlapping anchors, add the dismiss menu button to the menu. BUG=375379 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284496

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Fixed content description string #

Patch Set 4 : Updated content description #

Patch Set 5 : Add flag to show, fix menu width, and fix 4-item layout #

Patch Set 6 : Rebased #

Patch Set 7 : Fixed formatting #

Patch Set 8 : Avoid findbugs warning #

Patch Set 9 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -33 lines) Patch
A + chrome/android/java/res/drawable/btn_menu.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/res/layout/four_button_menu_item.xml View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 2 3 4 5 6 7 4 chunks +16 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 1 7 chunks +45 lines, -13 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
D chrome/android/shell/res/drawable/menu_dots.png View Binary file 0 comments Download
M chrome/android/shell/res/layout/chrome_shell_activity.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
David Trainor- moved to gerrit
ptal. This will probably land once we get the overlap anchor in the support lib.
6 years, 5 months ago (2014-07-11 23:07:42 UTC) #1
David Trainor- moved to gerrit
On 2014/07/11 23:07:42, David Trainor wrote: > ptal. This will probably land once we get ...
6 years, 5 months ago (2014-07-11 23:08:13 UTC) #2
aurimas (slooooooooow)
lgtm https://chromiumcodereview.appspot.com/381133003/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://chromiumcodereview.appspot.com/381133003/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode242 chrome/android/java/strings/android_chrome_strings.grd:242: Dismiss more options This does not sound right. ...
6 years, 5 months ago (2014-07-14 22:54:14 UTC) #3
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/381133003/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://chromiumcodereview.appspot.com/381133003/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode242 chrome/android/java/strings/android_chrome_strings.grd:242: Dismiss more options On 2014/07/14 22:54:14, aurimas wrote: > ...
6 years, 5 months ago (2014-07-15 00:46:32 UTC) #4
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 03:01:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/381133003/120001
6 years, 5 months ago (2014-07-18 03:04:14 UTC) #6
David Trainor- moved to gerrit
The CQ bit was unchecked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 03:13:34 UTC) #7
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 16:42:02 UTC) #8
David Trainor- moved to gerrit
The CQ bit was unchecked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 16:42:14 UTC) #9
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 17:14:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/381133003/140001
6 years, 5 months ago (2014-07-18 17:14:53 UTC) #11
David Trainor- moved to gerrit
The CQ bit was unchecked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-18 21:28:37 UTC) #12
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-21 20:07:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/381133003/160001
6 years, 5 months ago (2014-07-21 20:08:49 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 20:46:08 UTC) #15
Message was sent while issue was closed. 
Change committed as 284496

Powered by Google App Engine
This is Rietveld 408576698