Issue 381133002: Remove SkPicture copy constructor

Issue 381133002: Remove SkPicture copy constructor (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove SkPicture copy constructor Given where we're heading with SkPicture why would you need to make a copy? Committed: https://skia.googlesource.com/skia/+/dd528967fc3eea54c8d10937b0100192d0722f4e

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -90 lines)			Patch
M	include/core/SkPicture.h	View	1 2	3 chunks	+0 lines, -8 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 2	3 chunks	+0 lines, -44 lines	0 comments	Download
M	src/core/SkPictureData.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkPictureData.cpp	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	tests/PictureTest.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 9 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-10 17:42:21 UTC) #4

robertphillips

The CQ bit was unchecked by robertphillips@google.com

6 years, 5 months ago (2014-07-10 17:43:02 UTC) #5

robertphillips

This is paused until we can remove Chromium's use of the copy ctor: Skia: Add ...

6 years, 5 months ago (2014-07-10 19:08:16 UTC) #6

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-13 14:40:14 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/381133002/40001

6 years, 5 months ago (2014-07-13 14:40:51 UTC) #8

commit-bot: I haz the power

6 years, 5 months ago (2014-07-13 14:55:58 UTC) #9

Message was sent while issue was closed.

Change committed as dd528967fc3eea54c8d10937b0100192d0722f4e