Video Player: Add a cast menu

Video Player: Add a cast menu

This patch adds the menu and the list of casts. The menu just shows the menu, casting feature is not implemented.

All changes are effective only when the command line flag is specified. And the resource (cast icons) may change later.

Major changes:
- Detect Cast extension and load it
- Discover casts and show them on the menu

BUG=305511
TEST=manually testted

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282609

[yoshiki, 2014-07-11 02:26:41]

@fukino-san, could you take a look? Thanks.

[fukino, 2014-07-11 04:35:51]

Found some nits about style. Could you take a look?

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/css/cast_menu.css (right):

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/css/cast_menu.css:6: position: absolute;
nit: properties should be sorted.

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/css/cast_menu.css:19: background-color: #ffffff;
nit: using shorthand notation '#fff' is encouraged by Chromium style guide.

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/css/cast_menu.css:26: background-color: #eeeeee;
ditto: '#eee'

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/cast/cast_extension_discoverer.js (right):

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:1:
cofgocippekhfcmgfj - / Copyright 2014 The Chromium Authors. All rights reserved.
seems leading dust?

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:42: if (index
== CastExtensionDiscoverer.CAST_EXTENSION_IDS.length) {
nit: seems '===' can be used

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/caster.js:14: * @type {string}
nit: @const

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/cast/load_cast_extension_api.js (right):

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/load_cast_extension_api.js:50: return null;
nit: Chromium coding style says "Do not use braces for single-line logic
blocks." (Though using block for single-line seems common...)

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/load_cast_extension_api.js:81: return;
ditto

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/load_cast_extension_api.js:86: return;
ditto

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/video_player.js:174: }.wrap(this));
null is OK for now?

https://codereview.chromium.org/381073003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/video_player.js:360:
VideoPlayer.prototype.setCastList= function(casts) {
nit: A space missing before '='

[yoshiki, 2014-07-11 06:30:25]

@fukino, thanks for reviewing. PTAL.

[fukino, 2014-07-11 06:34:04]

On 2014/07/11 06:30:25, yoshiki wrote:
> @fukino, thanks for reviewing. PTAL.

LGTM. thanks!

[yoshiki, 2014-07-11 06:45:03]

Thanks!

[yoshiki, 2014-07-11 06:45:15]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-07-11 06:46:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/381073003/60001

[commit-bot: I haz the power, 2014-07-11 08:42:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-11 10:45:52]

Change committed as 282609