Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: net/extras/sqlite/sqlite_channel_id_store.h

Issue 381073002: Move sqlite_channel_id_store from chrome/browser/net to net/extras. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ryan's comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/extras/sqlite/sqlite_channel_id_store.h
diff --git a/chrome/browser/net/sqlite_channel_id_store.h b/net/extras/sqlite/sqlite_channel_id_store.h
similarity index 52%
rename from chrome/browser/net/sqlite_channel_id_store.h
rename to net/extras/sqlite/sqlite_channel_id_store.h
index 13fe5322556f5368e1fa8c19728b866cf3438562..79a6da13eaf089f304c12a81a631bf952415bb9a 100644
--- a/chrome/browser/net/sqlite_channel_id_store.h
+++ b/net/extras/sqlite/sqlite_channel_id_store.h
@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_NET_SQLITE_CHANNEL_ID_STORE_H_
-#define CHROME_BROWSER_NET_SQLITE_CHANNEL_ID_STORE_H_
+#ifndef NET_EXTRAS_SQLITE_SQLITE_CHANNEL_ID_STORE_H_
+#define NET_EXTRAS_SQLITE_SQLITE_CHANNEL_ID_STORE_H_
#include "base/callback_forward.h"
#include "base/compiler_specific.h"
+#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "net/ssl/default_channel_id_store.h"
@@ -15,36 +16,36 @@ class FilePath;
class SequencedTaskRunner;
}
-namespace quota {
-class SpecialStoragePolicy;
-}
+class GURL;
+
+namespace net {
-// Implements the net::DefaultChannelIDStore::PersistentStore interface
+// Implements the DefaultChannelIDStore::PersistentStore interface
// in terms of a SQLite database. For documentation about the actual member
// functions consult the documentation of the parent class
-// |net::DefaultChannelIDStore::PersistentCertStore|.
-// If provided, a |SpecialStoragePolicy| is consulted when the SQLite database
-// is closed to decide which certificates to keep.
-class SQLiteChannelIDStore
- : public net::DefaultChannelIDStore::PersistentStore {
+// DefaultChannelIDStore::PersistentCertStore.
+class SQLiteChannelIDStore : public DefaultChannelIDStore::PersistentStore {
public:
+ // Create or open persistent store in file |path|. All I/O tasks are performed
+ // in background using |background_task_runner|.
SQLiteChannelIDStore(
const base::FilePath& path,
- const scoped_refptr<base::SequencedTaskRunner>& background_task_runner,
- quota::SpecialStoragePolicy* special_storage_policy);
+ const scoped_refptr<base::SequencedTaskRunner>& background_task_runner);
- // net::DefaultChannelIDStore::PersistentStore:
+ // DefaultChannelIDStore::PersistentStore:
virtual void Load(const LoadedCallback& loaded_callback) OVERRIDE;
virtual void AddChannelID(
- const net::DefaultChannelIDStore::ChannelID& channel_id) OVERRIDE;
+ const DefaultChannelIDStore::ChannelID& channel_id) OVERRIDE;
virtual void DeleteChannelID(
- const net::DefaultChannelIDStore::ChannelID& channel_idx) OVERRIDE;
+ const DefaultChannelIDStore::ChannelID& channel_id) OVERRIDE;
virtual void SetForceKeepSessionState() OVERRIDE;
- protected:
- virtual ~SQLiteChannelIDStore();
+ // Delete channel ids for all servers in |server_identifiers|.
+ void DeleteAll(const std::vector<std::string>& server_identifiers);
mmenke 2014/08/12 17:12:34 Need to include vector and string headers.
mmenke 2014/08/12 17:12:35 optional nit: I think "DeleteAll" is a little con
mef 2014/08/12 19:33:28 Done.
mef 2014/08/12 19:33:28 Done.
private:
+ virtual ~SQLiteChannelIDStore();
+
class Backend;
scoped_refptr<Backend> backend_;
@@ -52,4 +53,6 @@ class SQLiteChannelIDStore
DISALLOW_COPY_AND_ASSIGN(SQLiteChannelIDStore);
};
-#endif // CHROME_BROWSER_NET_SQLITE_CHANNEL_ID_STORE_H_
+} // namespace net
+
+#endif // NET_EXTRAS_SQLITE_SQLITE_CHANNEL_ID_STORE_H_

Powered by Google App Engine
This is Rietveld 408576698