Move sqlite_channel_id_store from chrome/browser/net to net/extras.

content/browser/net/quota_policy_channel_id_store.h

Index: content/browser/net/quota_policy_channel_id_store.h
diff --git a/content/browser/net/quota_policy_channel_id_store.h b/content/browser/net/quota_policy_channel_id_store.h
new file mode 100644
index 0000000000000000000000000000000000000000..ac6aef6818e0ca2ce1dacb3ade302f856a894880
--- /dev/null
+++ b/content/browser/net/quota_policy_channel_id_store.h
@@ -0,0 +1,67 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_NET_QUOTA_POLICY_CHANNEL_ID_STORE_H_
+#define CONTENT_BROWSER_NET_QUOTA_POLICY_CHANNEL_ID_STORE_H_
+
+#include "base/callback_forward.h"
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+#include "content/common/content_export.h"
+#include "net/ssl/default_channel_id_store.h"
+
+namespace base {
+class FilePath;
+class SequencedTaskRunner;
+}
+
+namespace quota {
+class SpecialStoragePolicy;
+}
+
+namespace content {
+
+// Persistent ChannelID Store that takes into account SpecialStoragePolicy and
+// removes ChannelIDs that are StorageSessionOnly when store is closed.
+class CONTENT_EXPORT QuotaPolicyChannelIDStore
+    : public net::DefaultChannelIDStore::PersistentStore {
+ public:
+  QuotaPolicyChannelIDStore(
+      const base::FilePath& path,
+      const scoped_refptr<base::SequencedTaskRunner>& background_task_runner,
+      quota::SpecialStoragePolicy* special_storage_policy);

[Ryan Sleevi, 2014/08/06 22:39:58]

Document

[mef, 2014/08/07 17:40:58]

Done. I think. If not, could you elaborate?

+
+  // net::DefaultChannelIDStore::PersistentStore:
+  virtual void Load(const LoadedCallback& loaded_callback) OVERRIDE;
+  virtual void AddChannelID(
+      const net::DefaultChannelIDStore::ChannelID& channel_id) OVERRIDE;
+  virtual void DeleteChannelID(
+      const net::DefaultChannelIDStore::ChannelID& channel_id) OVERRIDE;
+  virtual void SetForceKeepSessionState() OVERRIDE;
+
+ private:

[Ryan Sleevi, 2014/08/06 22:39:58]

Unnecessary double private. Combine with 48

[mef, 2014/08/07 17:40:58]

Done.

+  virtual ~QuotaPolicyChannelIDStore();
+
+ private:
+  typedef ScopedVector<net::DefaultChannelIDStore::ChannelID> ChannelIDVector;
+  static void ApplyPolicyOnShutdown(
+      scoped_refptr<net::DefaultChannelIDStore::PersistentStore> shutdown_store,

[Ryan Sleevi, 2014/08/06 22:39:58]

const scoped_refptr<...>&

[mef, 2014/08/07 17:40:58]

Done.

+      quota::SpecialStoragePolicy* special_storage_policy,
+      scoped_ptr<ChannelIDVector> channel_ids);

[Ryan Sleevi, 2014/08/06 22:39:58]

This doesn't need to be a class static, does it? Seems to be accessing all
public methods. Move it into the .cc in an unnamed namespace?

[mef, 2014/08/07 17:40:58]

Done.

+
+  // True if everything should go to persistent store.
+  bool force_keep_session_state_;
+  const base::FilePath& path_;
+  scoped_refptr<base::SequencedTaskRunner> background_task_runner_;
+  scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy_;
+  scoped_refptr<net::DefaultChannelIDStore::PersistentStore> persistent_;

[Ryan Sleevi, 2014/08/06 22:39:58]

naming: persistent_store_

[mef, 2014/08/07 17:40:58]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(QuotaPolicyChannelIDStore);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_NET_QUOTA_POLICY_CHANNEL_ID_STORE_H_