PRESUBMIT.py - Issue 381043002: Add a virtualenv-based python bootstrapping service to infra.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 381043002: Add a virtualenv-based python bootstrapping service to infra. (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master

Patch Set: Address comments, add warning while building on Ubuntu Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « DEPS ('k') | README.md » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for buildbot.	5 """Top-level presubmit script for buildbot.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

11	11

12 DISABLED_TESTS = [	12 DISABLED_TESTS = [

13 '.*appengine/chromium_status/tests/main_test.py',	13 '.*appengine/chromium_status/tests/main_test.py',

14 '.*appengine/chromium_build/app_test.py',	14 '.*appengine/chromium_build/app_test.py',

15 ]	15 ]

16	16

17	17

18 DISABLED_PROJECTS = [	18 DISABLED_PROJECTS = [

19 'appengine/chromium_build',	19 'appengine/chromium_build',

20 'infra/services/lkgr_finder',	20 'infra/services/lkgr_finder',

21 'infra/services/gnumbd',	21 'infra/services/gnumbd',

22 'infra/ext/[^/]/.',

23 ]	22 ]

24	23

25	24

26 def CommonChecks(input_api, output_api):	25 def CommonChecks(input_api, output_api):

27 tests = []	26 tests = []

28	27

29 blacklist = list(input_api.DEFAULT_BLACK_LIST) + DISABLED_PROJECTS	28 blacklist = list(input_api.DEFAULT_BLACK_LIST) + DISABLED_PROJECTS

30	29

31 status_output = input_api.subprocess.check_output(	30 status_output = input_api.subprocess.check_output(

32 ['git', 'status', '--porcelain', '--ignored'])	31 ['git', 'status', '--porcelain', '--ignored'])

(...skipping 29 matching lines...) Expand all Loading...
62	61

63	62

64 def CheckChangeOnUpload(input_api, output_api):	63 def CheckChangeOnUpload(input_api, output_api):

65 return CommonChecks(input_api, output_api)	64 return CommonChecks(input_api, output_api)

66	65

67	66

68 def CheckChangeOnCommit(input_api, output_api):	67 def CheckChangeOnCommit(input_api, output_api):

69 output = CommonChecks(input_api, output_api)	68 output = CommonChecks(input_api, output_api)

70 output.extend(input_api.canned_checks.CheckOwners(input_api, output_api))	69 output.extend(input_api.canned_checks.CheckOwners(input_api, output_api))

71 return output	70 return output

OLD	NEW