bootstrap/bootstrap_wheel_wheel.sh - Issue 381043002: Add a virtualenv-based python bootstrapping service to infra.

Side by Side Diff: bootstrap/bootstrap_wheel_wheel.sh

Issue 381043002: Add a virtualenv-based python bootstrapping service to infra. (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 # Script to bootstrap the 'wheel' wheel from deps.pst. You only need to run

	4 # this when upgrading the wheel wheel in deps.pst, or when initializing the

	5 # google storage bucket from scratch.

	6
	dnj 2014/07/10 16:06:18 Consider doing a script path discovery and constru Consider doing a script path discovery and constructing paths from that. This would allow someone to run the script in another directory and still have it work. Alternatively you could assert "$0 == ./bootstrap_wheel_wheel.sh". iannucci 2014/07/11 02:14:45 Done. Show quoted text On 2014/07/10 16:06:18, dnj wrote: > Consider doing a script path discovery and constructing paths from that. This > would allow someone to run the script in another directory and still have it > work. > > Alternatively you could assert "$0 == ./bootstrap_wheel_wheel.sh". Done.
	7 ./bootstrap.py --env_path BUILD_ENV

	8

	9 . ./BUILD_ENV/bin/activate

	10

	11 read -r -d '' PROG <<EOF
	dnj 2014/07/10 16:06:18 Consider exporting this to a "bootstrap_wheel_whee Consider exporting this to a "bootstrap_wheel_wheel_pre.py" script and just running it. This would be pylintable and (IMO) cleaner. iannucci 2014/07/11 02:14:46 meh. there's already too many files here. Having t Show quoted text On 2014/07/10 16:06:18, dnj wrote: > Consider exporting this to a "bootstrap_wheel_wheel_pre.py" script and just > running it. This would be pylintable and (IMO) cleaner. meh. there's already too many files here. Having this script self-contained is more important, imo.
	12 import bootstrap

	13 print bootstrap.read_deps('deps.pst')['wheel']['gs']

	14 EOF

	15 SHA=$(echo "$PROG" \| python -)
	dnj 2014/07/10 16:06:18 Either set "-e" (errexit) or explicitly check the Either set "-e" (errexit) or explicitly check the return value. iannucci 2014/07/11 02:14:46 Done. Show quoted text On 2014/07/10 16:06:18, dnj wrote: > Either set "-e" (errexit) or explicitly check the return value. Done.
	16

	17 pip install wheel "https://storage.googleapis.com/chrome-python-wheelhouse/sourc es/$SHA"

	18

	19 rm -rf wheelhouse
	dnj 2014/07/10 16:06:17 Surround this w/ a directory check and maybe print Surround this w/ a directory check and maybe print a notice or something that you're deleting user files. iannucci 2014/07/11 02:14:45 wheelhouse is only used by these scripts for build Show quoted text On 2014/07/10 16:06:17, dnj wrote: > Surround this w/ a directory check and maybe print a notice or something that > you're deleting user files. wheelhouse is only used by these scripts for building. If the user puts stuff in there... um... ??
	20 mkdir wheelhouse

	21

	22 python - <<EOF
	dnj 2014/07/10 16:06:18 Consider exporting this to a "bootstrap_wheel_whee Consider exporting this to a "bootstrap_wheel_wheel_post.py" script and just running it. This would be pylintable and (IMO) cleaner. iannucci 2014/07/11 02:14:45 Acknowledged. Show quoted text On 2014/07/10 16:06:18, dnj wrote: > Consider exporting this to a "bootstrap_wheel_wheel_post.py" script and just > running it. This would be pylintable and (IMO) cleaner. Acknowledged.
	23 import build_deps

	24 import bootstrap

	25 build = bootstrap.read_deps('deps.pst')['wheel']['build']

	26 build_deps.process_gs('wheel', '$SHA', build)

	27 build_deps.push_wheelhouse()

	28 EOF

OLD	NEW

« bootstrap/bootstrap.py ('K') | « bootstrap/bootstrap.py ('k') | bootstrap/build_deps.py » ('j') | bootstrap/build_deps.py » ('J')