Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 380953002: Set callback interface on WebCDMSessionImpl after creation. (Closed)

Created:
6 years, 5 months ago by jrummell
Modified:
6 years, 5 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set callback interface on WebCDMSessionImpl after creation. In order to allow MediaKeySession to be created only when resolving the promise, add the ability to set the client callback interface on WebContentDecryptionModuleSessionImpl after the object is created. This will be used in a subsequent CL to update blink. Requires a third change to remove the old methods once blink is updated. BUG=358271 TEST=EME layouts tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283854

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase + change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M content/renderer/media/cdm_session_adapter.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/cdm_session_adapter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/webcontentdecryptionmodule_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webcontentdecryptionmodule_impl.cc View 1 chunk +8 lines, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jrummell
PTAL. blink changes in https://codereview.chromium.org/379343003/.
6 years, 5 months ago (2014-07-09 23:53:27 UTC) #1
ddorwin
LG, but let's explore the Blink side more before landing. https://codereview.chromium.org/380953002/diff/1/content/renderer/media/webcontentdecryptionmodulesession_impl.cc File content/renderer/media/webcontentdecryptionmodulesession_impl.cc (right): https://codereview.chromium.org/380953002/diff/1/content/renderer/media/webcontentdecryptionmodulesession_impl.cc#newcode214 ...
6 years, 5 months ago (2014-07-10 23:22:41 UTC) #2
jrummell
Updated. https://codereview.chromium.org/380953002/diff/1/content/renderer/media/webcontentdecryptionmodulesession_impl.cc File content/renderer/media/webcontentdecryptionmodulesession_impl.cc (right): https://codereview.chromium.org/380953002/diff/1/content/renderer/media/webcontentdecryptionmodulesession_impl.cc#newcode214 content/renderer/media/webcontentdecryptionmodulesession_impl.cc:214: client_->message( On 2014/07/10 23:22:41, ddorwin wrote: > This ...
6 years, 5 months ago (2014-07-17 00:56:55 UTC) #3
ddorwin
LGTM, but let's get the public APIs reviewed before landing this.
6 years, 5 months ago (2014-07-17 01:02:33 UTC) #4
jrummell
The CQ bit was checked by jrummell@chromium.org
6 years, 5 months ago (2014-07-17 17:39:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/380953002/20001
6 years, 5 months ago (2014-07-17 17:41:40 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:24:14 UTC) #7
Message was sent while issue was closed.
Change committed as 283854

Powered by Google App Engine
This is Rietveld 408576698