Added battery level and time to the status tray's accessible name.

ash/system/tray/system_tray.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray.h"
 
 #include "ash/ash_switches.h"
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
@@ skipping 570 matching lines @@
       height = std::max(
           0, work_area.height() - bubble_view->GetBoundsInScreen().y());
     } else {
       height = std::max(
           0, bubble_view->GetBoundsInScreen().bottom() - work_area.y());
     }
   }
   status_area_widget()->web_notification_tray()->SetSystemTrayHeight(height);
 }
 
+base::string16 SystemTray::GetAccessibleTimeString(
+    const base::Time& now) const {
+  base::HourClockType hour_type =
+      ash::Shell::GetInstance()->system_tray_delegate()->GetHourClockType();
+  return base::TimeFormatTimeOfDayWithHourClockType(

[Peter Lundblad, 2014/07/09 23:08:11]

Just to make sure, can you try this with the setting for 24 hour time instead of
12 hour time.

[evy, 2014/07/10 17:19:57]

24 hour time is read very strange (oh nine. one one.)
But this is a thing that already happened in the current status tray time
reading, and Dominic said it's probably out of our project scope.
However, nothing breaks - so that's good!
I think I'll have it read the word time before it reads the time, so that it's
clear that "oh nine. one one." is a time.

+      now, hour_type, base::kKeepAmPm);
+}
+
 void SystemTray::SetShelfAlignment(ShelfAlignment alignment) {
   if (alignment == shelf_alignment())
     return;
   TrayBackgroundView::SetShelfAlignment(alignment);
   UpdateAfterShelfAlignmentChange(alignment);
   // Destroy any existing bubble so that it is rebuilt correctly.
   CloseSystemBubbleAndDeactivateSystemTray();
   // Rebuild any notification bubble.
   if (notification_bubble_) {
     notification_bubble_.reset();
     UpdateNotificationBubble();
   }
 }
 
 void SystemTray::AnchorUpdated() {
   if (notification_bubble_) {
     notification_bubble_->bubble_view()->UpdateBubble();
     // Ensure that the notification buble is above the shelf/status area.
     notification_bubble_->bubble_view()->GetWidget()->StackAtTop();
     UpdateBubbleViewArrow(notification_bubble_->bubble_view());
   }
   if (system_bubble_) {
     system_bubble_->bubble_view()->UpdateBubble();
     UpdateBubbleViewArrow(system_bubble_->bubble_view());
   }
 }
 
 base::string16 SystemTray::GetAccessibleNameForTray() {
-  return l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ACCESSIBLE_NAME);
+  base::string16 name =
+      l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ACCESSIBLE_NAME);
+  base::string16 time = GetAccessibleTimeString(base::Time::Now());
+  base::string16 battery = PowerStatus::Get()->GetShortAccessibleNameString();
+  return name + base::ASCIIToUTF16(". ") +

[dmazzoni, 2014/07/10 16:23:16]

This is borderline, but this is usually the best practice for string combining,
rather than concatenating.

l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ACCESSIBLE_DESCRIPTION,
  PowerStatus::Get()->GetShortAccessibleNameString(),
  GetAccessibleTimeString(base::Time::Now())

where the string is something like:

"Status tray, $1, current time $2"

[evy, 2014/07/10 17:19:57]

Done.

+         time + base::ASCIIToUTF16(". ") +
+         battery;
 }
 
 void SystemTray::BubbleResized(const TrayBubbleView* bubble_view) {
   UpdateWebNotifications();
 }
 
 void SystemTray::HideBubbleWithView(const TrayBubbleView* bubble_view) {
   if (system_bubble_.get() && bubble_view == system_bubble_->bubble_view()) {
     DestroySystemBubble();
     UpdateNotificationBubble();  // State changed, re-create notifications.
@@ skipping 77 matching lines @@
   system_bubble_.reset();
   // When closing a system bubble with the alternate shelf layout, we need to
   // turn off the active tinting of the shelf.
   if (full_system_tray_menu_) {
     SetDrawBackgroundAsActive(false);
     full_system_tray_menu_ = false;
   }
 }
 
 }  // namespace ash