Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 380913003: Fixes for re-enabling more MSVC level 4 warnings: base/ edition #2 (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Fixes for re-enabling more MSVC level 4 warnings: base/ edition #2 This contains fixes for the following sorts of issues: * Signedness mismatch Defining UChar32 as a signed type may look wrong, but it's actually how the type is already defined over in third_party/icu/. BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282255

Patch Set 1 #

Patch Set 2 : Fix a few more issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/strings/string_util.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/third_party/icu/icu_utf.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Kasting
6 years, 5 months ago (2014-07-09 23:09:01 UTC) #1
awong
...scared...LGTM Eek. Matching makes sense, but that's scary to have the type name express the ...
6 years, 5 months ago (2014-07-09 23:15:15 UTC) #2
awong
Oh...do they mean unicodechar32, not unsinged char32?
6 years, 5 months ago (2014-07-09 23:15:50 UTC) #3
Peter Kasting
On 2014/07/09 23:15:50, awong wrote: > Oh...do they mean unicodechar32, not unsinged char32? I didn't ...
6 years, 5 months ago (2014-07-09 23:29:22 UTC) #4
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-09 23:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/380913003/20001
6 years, 5 months ago (2014-07-09 23:31:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 02:47:41 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 04:38:05 UTC) #8
Message was sent while issue was closed.
Change committed as 282255

Powered by Google App Engine
This is Rietveld 408576698