Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: build/android/developer_recommended_flags.gypi

Issue 380913002: Fix component build failure for users of developer_recommended_flags.gypi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/developer_recommended_flags.gypi
diff --git a/build/android/developer_recommended_flags.gypi b/build/android/developer_recommended_flags.gypi
index 28470963c24b0990c4592a65bce2e8588b7bda4b..220a623e96bfdfc92cf3c218af24e43180f8c567 100644
--- a/build/android/developer_recommended_flags.gypi
+++ b/build/android/developer_recommended_flags.gypi
@@ -23,15 +23,18 @@
{
'variables': {
+ 'variables': {
jdduke (slow) 2014/07/09 22:29:51 Is it self explanatory why the variable should be
+ # Set component to 'shared_library' to enable the component build. This builds native code as
+ # many small shared libraries instead of one monolithic library. This slightly reduces the time
+ # required for incremental builds.
+ 'component%': 'shared_library',
+ },
+ 'component%': '<(component)',
+
# When set to 1, only write jni generated files if they've changed. This can prevent unnecessary
# compiling/linking of native libraries when editing java files.
'optimize_jni_generation%': 1,
- # Set component to 'shared_library' to enable the component build. This builds native code as
- # many small shared libraries instead of one monolithic library. This slightly reduces the time
- # required for incremental builds.
- 'component%': 'shared_library',
-
# When gyp_managed_install is set to 1, building an APK will install that APK on the connected
# device(/emulator). To install on multiple devices (or onto a new device), build the APK once
# with each device attached. This greatly reduces the time required for incremental builds.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698