Issue 380913002: Fix component build failure for users of developer_recommended_flags.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380913002: Fix component build failure for users of developer_recommended_flags.gypi (Closed)

Created:
6 years, 5 months ago by aurimas (slooooooooow)

Modified:
6 years, 5 months ago

Reviewers:
cjhopman, jdduke (slow), Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix component build failure for users of developer_recommended_flags.gypi BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282149

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	build/android/developer_recommended_flags.gypi	View		1 chunk	+8 lines, -5 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

Seems OK assuming it works but I'll defer to the gyp experts :) https://codereview.chromium.org/380913002/diff/1/build/android/developer_recommended_flags.gypi File ...

6 years, 5 months ago (2014-07-09 22:29:51 UTC) #3

aurimas (slooooooooow)

The CQ bit was checked by aurimas@chromium.org

6 years, 5 months ago (2014-07-09 22:33:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/380913002/1

6 years, 5 months ago (2014-07-09 22:35:25 UTC) #6

Message was sent while issue was closed.

Change committed as 282149

Expand Messages | Collapse Messages