Issue 380903002: Rebase oscillator tests for Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380903002: Rebase oscillator tests for Windows (Closed)

Created:
6 years, 5 months ago by Raymond Toy

Modified:
6 years, 5 months ago

Reviewers:

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Rebase oscillator tests for Windows The expected sine result was way off for some reason. I compared this new result with the linux version and they now differ by at most 1 ulp The other tests just differ by at most 1 ulp too. I think these differences are due to the switch to SSE2 on windows. BUG=309197, 320099 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177859

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
M	LayoutTests/TestExpectations	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
M	LayoutTests/platform/win/webaudio/oscillator-custom-expected.wav	View		Binary file		0 comments	Download
M	LayoutTests/platform/win/webaudio/oscillator-sine-expected.wav	View		Binary file		0 comments	Download
M	LayoutTests/platform/win/webaudio/oscillator-square-expected.wav	View		Binary file		0 comments	Download
M	LayoutTests/platform/win/webaudio/oscillator-triangle-expected.wav	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy

Committed patchset #2 manually as r177859 (presubmit successful).

6 years, 5 months ago (2014-07-10 17:32:52 UTC) #1

Justin Novosad

6 years, 5 months ago (2014-07-10 18:57:39 UTC) #2

Message was sent while issue was closed.

On 2014/07/10 17:32:52, Raymond Toy wrote:
> Committed patchset #2 manually as r177859 (presubmit successful).

Gardening: Reverted manually as r177869
All the rebased tests are failing on windows

Expand Messages | Collapse Messages