chrome/browser/resources/options/website_settings.html - Issue 380893005: Add an option page for searching and managing resources and permissions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/website_settings.html

Issue 380893005: Add an option page for searching and managing resources and permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/options/website_settings.css ('K') | « chrome/browser/resources/options/website_settings.css ('k') | chrome/browser/resources/options/website_settings.js » ('j') | chrome/browser/resources/options/website_settings.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id="website-settings-page" class="page website-settings-page" hidden>

	2 <div class="close-button"></div>

	3 <h1 i18n-content="websiteSettingsPage"></h1>

	4 <div class="content-area website-list-content-area">

	5 <div class="website-column-headers">

	6 <div class="website-header-controls">

	7 <select id="resourceType" class="resource-type-select">

	8 <option value="geolocation" i18n-content="websitesLabelGeolocation">

	9 </option>

	10 <option value="media-stream" i18n-content="websitesLabelMediaStream"

	11 ></option>
	Dan Beam 2014/07/15 03:39:15 nit: either <option value="media-stream" nit: either <option value="media-stream" i18n-content="websitesLabelMediaStream"></option> or <option value="media-stream" i18n-content="websitesLabelMediaStream"> </option> Daniel Nishi 2014/07/15 17:12:54 Done with the second. Show quoted text On 2014/07/15 03:39:15, Dan Beam wrote: > nit: either > > <option value="media-stream" > i18n-content="websitesLabelMediaStream"></option> > > or > > <option value="media-stream" i18n-content="websitesLabelMediaStream"> > </option> Done with the second.
	12 <option value="notifications"

	13 i18n-content="websitesLabelNotifications"></option>

	14 </select>

	15 <input type="search" class="website-settings-search-box"

	16 i18n-values="placeholder:websitesSearch" incremental>

	17 </div>

	18 </div>

	19 <list id="origin-list" class="origin-list"></list>

	20 </div>

	21 <div class="action-area">

	22 <div class="button-strip">

	23 <button id="website-settings-overlay-confirm" i18n-content="done">

	24 </button>

	25 </div>

	26 </div>

	27 </div>

OLD	NEW