chrome/browser/resources/options/website_settings.css - Issue 380893005: Add an option page for searching and managing resources and permissions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/website_settings.css

Issue 380893005: Add an option page for searching and managing resources and permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/options/origin_resources_list.js ('K') | « chrome/browser/resources/options/origin_resources_list.js ('k') | chrome/browser/resources/options/website_settings.html » ('j') | chrome/browser/resources/options/website_settings.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2014 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 /* Styles for the website settings page. */

	6 .website-settings-page {

	7 margin-left: -15px;
	Dan Beam 2014/07/10 02:57:23 any {margin,padding}-left -> -webkit-{margin,paddi any {margin,padding}-left -> -webkit-{margin,padding}-start any {margin,padding}-right -> -webkit-{margin,padding}-end so it'll work in RTL (right-to-left languages like hebrew or arabic). that said, why do you need a negative margin here? Daniel Nishi 2014/07/10 19:00:08 Haven't done much work with CSS before, so I cargo Show quoted text On 2014/07/10 02:57:23, Dan Beam wrote: > any {margin,padding}-left -> -webkit-{margin,padding}-start > any {margin,padding}-right -> -webkit-{margin,padding}-end > > so it'll work in RTL (right-to-left languages like hebrew or arabic). > > that said, why do you need a negative margin here? Haven't done much work with CSS before, so I cargo culted that over. Removed now.
	8 width: 540px;

	9 }

	10

	11 .resource-type-select {

	12 margin-right: 17em;
	Dan Beam 2014/07/10 02:57:23 this is not the right way to put the search box to this is not the right way to put the search box to the right side of the dialog, i'd recommend using flexbox or a table or lots of other ways Daniel Nishi 2014/07/10 19:00:08 Replaced with flex and a margin-right:auto. Show quoted text On 2014/07/10 02:57:23, Dan Beam wrote: > this is not the right way to put the search box to the right side of the dialog, > i'd recommend using flexbox or a table or lots of other ways Replaced with flex and a margin-right:auto.
	13 }

	14

	15 /* Styles for the origin list elements in the website settings page.. */
	Dan Beam 2014/07/10 02:57:23 nit: .. -> . nit: .. -> . Daniel Nishi 2014/07/10 19:00:08 Done. Show quoted text On 2014/07/10 02:57:23, Dan Beam wrote: > nit: .. -> . Done.
	16 .origin-list {

	17 border: 1px solid #D9D9D9;
	Dan Beam 2014/07/10 02:57:23 nit: d9d9d9 (lowercase) nit: d9d9d9 (lowercase) Daniel Nishi 2014/07/10 19:00:08 Done. Show quoted text On 2014/07/10 02:57:23, Dan Beam wrote: > nit: d9d9d9 (lowercase) Done.
	18 margin: 0;

	19 margin-top: 5px;
	Dan Beam 2014/07/10 02:57:23 nit: margin: 5px 0 0; nit: margin: 5px 0 0; Daniel Nishi 2014/07/10 19:00:08 Done. Show quoted text On 2014/07/10 02:57:23, Dan Beam wrote: > nit: margin: 5px 0 0; Done.
	20 min-height: 0;

	21 }

OLD	NEW