Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: cc/quads/render_pass.cc

Issue 380893004: Move Copy method from DrawQuad to RenderPass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moreRP4DQ
Patch Set: add RP to DQ_unittests to test Copy Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/quads/render_pass.cc
diff --git a/cc/quads/render_pass.cc b/cc/quads/render_pass.cc
index 70161667ad23d2bfbb4105bdcf2f016195534a09..e4350ba81c90c64900c62e4c63e3f6dae0c169fd 100644
--- a/cc/quads/render_pass.cc
+++ b/cc/quads/render_pass.cc
@@ -107,12 +107,14 @@ void RenderPass::CopyAll(const ScopedPtrVector<RenderPass>& in,
if (quad->material == DrawQuad::RENDER_PASS) {
const RenderPassDrawQuad* pass_quad =
RenderPassDrawQuad::MaterialCast(quad);
- copy_pass->quad_list.push_back(
- pass_quad->Copy(copy_pass->shared_quad_state_list[sqs_i],
- pass_quad->render_pass_id).PassAs<DrawQuad>());
+ RenderPassDrawQuad* copy_quad =
+ copy_pass->CopyFromAndAppendTypedDrawQuad<RenderPassDrawQuad>(
danakj 2014/07/10 19:53:25 Why not copy_pass->CopyFromAndAppendRenderPassDraw
weiliangc 2014/07/11 15:59:12 Done.
+ pass_quad);
+ copy_quad->shared_quad_state = copy_pass->shared_quad_state_list[sqs_i];
+ copy_quad->render_pass_id = pass_quad->render_pass_id;
} else {
- copy_pass->quad_list.push_back(source->quad_list[i]->Copy(
- copy_pass->shared_quad_state_list[sqs_i]));
+ copy_pass->CopyFromAndAppendDrawQuad(
+ quad, copy_pass->shared_quad_state_list[sqs_i]);
}
}
out->push_back(copy_pass.Pass());

Powered by Google App Engine
This is Rietveld 408576698