Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: cc/layers/delegated_renderer_layer_impl.cc

Issue 380893004: Move Copy method from DrawQuad to RenderPass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moreRP4DQ
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/quads/draw_quad.h » ('j') | cc/quads/draw_quad_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/delegated_renderer_layer_impl.cc
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc
index e110ff7b67f82f49c986587c381a8b65f7237ce8..9d5e651e04ce6ec45febd794599a293a10d8148e 100644
--- a/cc/layers/delegated_renderer_layer_impl.cc
+++ b/cc/layers/delegated_renderer_layer_impl.cc
@@ -441,9 +441,9 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
if (quad_visible_rect.IsEmpty())
continue;
- scoped_ptr<DrawQuad> output_quad;
if (delegated_quad->material != DrawQuad::RENDER_PASS) {
- output_quad = delegated_quad->Copy(output_shared_quad_state);
+ DrawQuad* output_quad = render_pass->CopyFromAndAppendDrawQuad(
+ delegated_quad, output_shared_quad_state);
output_quad->visible_rect = quad_visible_rect;
} else {
RenderPass::Id delegated_contributing_render_pass_id =
@@ -460,15 +460,14 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
DCHECK(output_contributing_render_pass_id !=
append_quads_data->render_pass_id);
- output_quad = RenderPassDrawQuad::MaterialCast(delegated_quad)->Copy(
- output_shared_quad_state,
- output_contributing_render_pass_id).PassAs<DrawQuad>();
+ RenderPassDrawQuad* output_quad =
+ render_pass->CopyFromAndAppendRenderPassDrawQuad(
+ RenderPassDrawQuad::MaterialCast(delegated_quad),
+ output_shared_quad_state,
+ output_contributing_render_pass_id);
output_quad->visible_rect = quad_visible_rect;
}
}
-
- if (output_quad)
- render_pass->quad_list.push_back(output_quad.Pass());
}
}
« no previous file with comments | « no previous file | cc/quads/draw_quad.h » ('j') | cc/quads/draw_quad_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698