Move Copy method from DrawQuad to RenderPass

cc/quads/render_pass.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/quads/render_pass.h"
 
 #include "base/values.h"
 #include "cc/base/math_util.h"
 #include "cc/debug/traced_value.h"
 #include "cc/output/copy_output_request.h"
@@ skipping 89 matching lines @@
         DCHECK_LT(sqs_i, source->shared_quad_state_list.size());
       }
       DCHECK(source->quad_list[i]->shared_quad_state ==
              source->shared_quad_state_list[sqs_i]);
 
       DrawQuad* quad = source->quad_list[i];
 
       if (quad->material == DrawQuad::RENDER_PASS) {
         const RenderPassDrawQuad* pass_quad =
             RenderPassDrawQuad::MaterialCast(quad);
-        copy_pass->quad_list.push_back(
-            pass_quad->Copy(copy_pass->shared_quad_state_list[sqs_i],
-                            pass_quad->render_pass_id).PassAs<DrawQuad>());
+        RenderPassDrawQuad* copy_quad =
+            copy_pass->CopyFromAndAppendTypedDrawQuad<RenderPassDrawQuad>(

[danakj, 2014/07/10 19:53:25]

Why not copy_pass->CopyFromAndAppendRenderPassDrawQuad

[weiliangc, 2014/07/11 15:59:12]

Done.

+                pass_quad);
+        copy_quad->shared_quad_state = copy_pass->shared_quad_state_list[sqs_i];
+        copy_quad->render_pass_id = pass_quad->render_pass_id;
       } else {
-        copy_pass->quad_list.push_back(source->quad_list[i]->Copy(
-            copy_pass->shared_quad_state_list[sqs_i]));
+        copy_pass->CopyFromAndAppendDrawQuad(
+            quad, copy_pass->shared_quad_state_list[sqs_i]);
       }
     }
     out->push_back(copy_pass.Pass());
   }
 }
 
 void RenderPass::SetNew(Id id,
                         const gfx::Rect& output_rect,
                         const gfx::Rect& damage_rect,
                         const gfx::Transform& transform_to_root_target) {
@@ skipping 107 matching lines @@
     case DrawQuad::RENDER_PASS:
     case DrawQuad::INVALID:
       LOG(FATAL) << "Invalid DrawQuad material " << quad->material;
       break;
   }
   quad_list.back()->shared_quad_state = shared_quad_state;
   return quad_list.back();
 }
 
 }  // namespace cc