Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: ui/views/view.h

Issue 380813003: Remove remaining overrides of View::HitTestRect() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DoesIntersectRect() overrides made private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.h
diff --git a/ui/views/view.h b/ui/views/view.h
index 1bdee37cdbbaf3360fe8673a4ed79e3afcd9746b..510a6ba6475a95117566602a957526513d82ada1 100644
--- a/ui/views/view.h
+++ b/ui/views/view.h
@@ -577,16 +577,14 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// the cursor is a shared resource.
virtual gfx::NativeCursor GetCursor(const ui::MouseEvent& event);
- // TODO(tdanderson): HitTestPoint() and HitTestRect() will be removed once
- // their logic is moved into ViewTargeter and its
- // derived classes. See crbug.com/355425.
-
// A convenience function which calls HitTestRect() with a rect of size
// 1x1 and an origin of |point|.
bool HitTestPoint(const gfx::Point& point) const;
- // Tests whether |rect| intersects this view's bounds.
- virtual bool HitTestRect(const gfx::Rect& rect) const;
+ // Tests whether |rect| intersects this view's bounds using the ViewTargeter
+ // installed on |this|. If there is no ViewTargeter installed on |this|, the
+ // ViewTargeter installed on the root view is used instead.
+ bool HitTestRect(const gfx::Rect& rect) const;
// Returns true if this view or any of its descendants are permitted to
// be the target of an event.
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698